Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1812753002: - Move (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 9 months ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Move stack_limit_, stack_overflow_flags_, saved_stack_limit_, stack_overflow_count_ and other interrupts mask fields from Isolate structure to Thread structure - Change the stack overflow check in the prolog to load the stack limit from the THR register, this removes the back to back dependent loads to load the stack limit from the Isolate structure R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/56e888d4cda13e7d6d008f44a34460bd499d09e7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -459 lines) Patch
M runtime/vm/code_generator.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/dart_entry.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +3 lines, -17 lines 1 comment Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +3 lines, -17 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +3 lines, -17 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M runtime/vm/isolate.h View 8 chunks +5 lines, -84 lines 0 comments Download
M runtime/vm/isolate.cc View 10 chunks +16 lines, -177 lines 0 comments Download
M runtime/vm/isolate_test.cc View 5 chunks +66 lines, -64 lines 0 comments Download
M runtime/vm/longjump.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/safepoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/store_buffer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/thread.h View 4 chunks +88 lines, -21 lines 0 comments Download
M runtime/vm/thread.cc View 5 chunks +188 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 9 months ago (2016-03-17 01:04:43 UTC) #2
Cutch
lgtm
4 years, 9 months ago (2016-03-17 16:00:16 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/1812753002/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/1812753002/diff/1/runtime/vm/intermediate_language_arm.cc#newcode2923 runtime/vm/intermediate_language_arm.cc:2923: __ ldr(IP, Address(THR, Thread::stack_limit_offset())); Nice!
4 years, 9 months ago (2016-03-17 17:08:26 UTC) #4
siva
4 years, 9 months ago (2016-03-17 19:57:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56e888d4cda13e7d6d008f44a34460bd499d09e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698