Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1812733002: Remove unnecessary inclusion of sys/syscall.h in base/logging.cc (Closed)

Created:
4 years, 9 months ago by Ben Chan
Modified:
4 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary inclusion of sys/syscall.h in base/logging.cc The inclusion of sys/syscall.h was introduced in crrev.com/4916 to obtain the current thread ID via `syscall(__NR_gettid)`. The code was later changed in crrev.com/118152 to use `base::PlatformThread::CurrentId()` instead. The inclusion of sys/syscall.h is no longer needed and thus removed by this CL. BUG=None Committed: https://crrev.com/3bf198b69c4ab5b2ebf0ebc6b5ddf285302be863 Cr-Commit-Position: refs/heads/master@{#381735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/logging.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Ben Chan
4 years, 9 months ago (2016-03-17 00:45:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812733002/1
4 years, 9 months ago (2016-03-17 02:02:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 03:26:38 UTC) #7
Mark Mentovai
LGTM
4 years, 9 months ago (2016-03-17 12:18:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812733002/1
4 years, 9 months ago (2016-03-17 17:07:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 17:12:42 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:14:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3bf198b69c4ab5b2ebf0ebc6b5ddf285302be863
Cr-Commit-Position: refs/heads/master@{#381735}

Powered by Google App Engine
This is Rietveld 408576698