Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: content/browser/download/save_file_manager.h

Issue 1812693002: Fix how Save-Page-As responds to web requests blocked by extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed new test (to help with merges into Beta and Stable branches). Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_file_manager.h
diff --git a/content/browser/download/save_file_manager.h b/content/browser/download/save_file_manager.h
index bb2451ed7479ea68842dfc137daaa0d66687297b..e99c2a23b8a7e32a918a585ce281db83a0644617 100644
--- a/content/browser/download/save_file_manager.h
+++ b/content/browser/download/save_file_manager.h
@@ -90,8 +90,10 @@ class SaveFileManager : public base::RefCountedThreadSafe<SaveFileManager> {
// Lifetime management.
CONTENT_EXPORT void Shutdown();
- // Save the specified URL. Called on the UI thread and forwarded to the
- // ResourceDispatcherHostImpl on the IO thread.
+ // Save the specified URL. Caller has to guarantee that |save_package| will
+ // be alive until the call to RemoveSaveFile. Called on the UI thread (and in
+ // case of network downloads forwarded to the ResourceDispatcherHostImpl on
+ // the IO thread).
void SaveURL(SaveItemId save_item_id,
const GURL& url,
const Referrer& referrer,
« no previous file with comments | « no previous file | content/browser/download/save_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698