BUILD.gn - Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: working with icu-case-mapping.js manually compiled in; gyp change not picking it up Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 46afb06e08eacd89984f394cd7ef716667bd7f9c..19d67e84aea643b531d92ca3dffd60b25058f920 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -349,6 +349,10 @@ action("js2c_experimental") {

"$target_gen_dir/experimental-libraries.cc",

]

+ if (v8_enable_i18n_support) {

+ sources += [ "src/js/icu-case-mapping.js" ]

+ }

args = [

rebase_path("$target_gen_dir/experimental-libraries.cc",

root_build_dir),

« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | src/bootstrapper.cc » ('J')