src/flag-definitions.h - Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Yang's comment addressed - return right away for no-change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index db1d7895291482ae6e2d47f9bd7ca28dea75386c..48a054d0b434a0b85f92be925685d56739be9c05 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -193,12 +193,22 @@ DEFINE_IMPLICATION(es_staging, harmony_regexp_lookbehind)

DEFINE_IMPLICATION(es_staging, move_object_start)

// Features that are still work in progress (behind individual flags).

+#ifdef V8_I18N_SUPPORT

+#define HARMONY_INPROGRESS(V) \

+ V(harmony_function_sent, "harmony function.sent") \

+ V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \

+ V(harmony_simd, "harmony simd") \

+ V(harmony_do_expressions, "harmony do-expressions") \

+ V(harmony_regexp_property, "harmony unicode regexp property classes") \

+ V(icu_case_mapping, "case mapping with ICU rather than Unibrow")

+#else

#define HARMONY_INPROGRESS(V) \

V(harmony_function_sent, "harmony function.sent") \

V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \

V(harmony_simd, "harmony simd") \

V(harmony_do_expressions, "harmony do-expressions") \

V(harmony_regexp_property, "harmony unicode regexp property classes")

+#endif

// Features that are complete (but still behind --harmony/es-staging flag).

#define HARMONY_STAGED(V) \

« no previous file with comments | « src/bootstrapper.cc ('k') | src/js/i18n.js » ('j') | src/js/i18n.js » ('J')