Use ICU case conversion/transliterator for case conversion behind a flag

tools/gyp/v8.gyp

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 1950 matching lines @@
           'toolsets': ['target'],
         }],
       ]
     },
     {
       'target_name': 'js2c',
       'type': 'none',
       'conditions': [
         ['want_separate_host_toolset==1', {
           'toolsets': ['host'],
         }, {

[jochen (gone - plz use gerrit), 2016/04/29 06:58:09]

this file doesn't exist anymore, it's now in src/

[jungshik at Google, 2016/04/29 18:03:23]

rebased. Thanks !

           'toolsets': ['target'],
         }],
-        ['v8_enable_i18n_support==1', {
-          'variables': {
-            'i18n_library_files': [
-              '../../src/js/i18n.js',
-            ],
-          },
-        }, {
-          'variables': {
-            'i18n_library_files': [],
-          },
-        }],
       ],
       'variables': {
         'library_files': [
           '../../src/js/macros.py',
           '../../src/messages.h',
           '../../src/js/prologue.js',
           '../../src/js/runtime.js',
           '../../src/js/v8natives.js',
           '../../src/js/symbol.js',
           '../../src/js/array.js',
@@ skipping 29 matching lines @@
           '../../src/js/harmony-simd.js',
           '../../src/js/harmony-species.js',
           '../../src/js/harmony-unicode-regexps.js',
           '../../src/js/harmony-string-padding.js',
           '../../src/js/promise-extra.js',
         ],
         'libraries_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries.bin',
         'libraries_experimental_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-experimental.bin',
         'libraries_extras_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-extras.bin',
         'libraries_experimental_extras_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-experimental-extras.bin',
+        'conditions': [
+          ['v8_enable_i18n_support==1', {
+            'library_files': ['../../src/js/i18n.js'],
+            'experimental_library_files': ['../../src/js/icu-case-mapping.js'],

[jungshik at Google, 2016/04/29 06:23:17]

For some reason, icu-case-mapping.js is never added to the list of js files to
be compiled by 'js2c' for
experimental-libraries.cc and libraries-experimental.bin. 

When I manually built those two files ( cc and bin) using the following commands
and d8 after that, d8 worked as expected. Without --icu_case_mapping, I got the
current
behavior and with --icu_case_mapping, I got a new correct behaviro for
to{Lower,Upper}Case. 

python ../tools/js2c.py ../out/Release/gen/experimental-libraries.cc
EXPERIMENTAL js/macros.py messages.h js/harmony-atomics.js
js/harmony-regexp-exec.js js/harmony-sharedarraybuffer.js js/harmony-simd.js
js/harmony-species.js js/harmony-unicode-regexps.js js/harmony-string-padding.js
js/promise-extra.js js/icu-case-mapping.js 

python ../tools/js2c.py ../out/Release/gen/experimental-libraries.cc
EXPERIMENTAL js/macros.py messages.h js/harmony-atomics.js
js/harmony-regexp-exec.js js/harmony-sharedarraybuffer.js js/harmony-simd.js
js/harmony-species.js js/harmony-unicode-regexps.js js/harmony-string-padding.js
js/promise-extra.js js/icu-case-mapping.js --startup_blob
../out/Release/gen/libraries-experimental.bin --nojs

I also wanted to try GN build, but it turned out that GN does not yet support a
standalone v8 build. 

[jochen (gone - plz use gerrit), 2016/04/29 06:58:09]

gyp is a bit peculiar here. I'd recommend to keep  i18n_library_files and add
i18n_experimental_library_files

+          }],
+        ],
       },
       'actions': [
         {
           'action_name': 'js2c',
           'inputs': [
             '../../tools/js2c.py',
             '<@(library_files)',
-            '<@(i18n_library_files)'
           ],
           'outputs': ['<(SHARED_INTERMEDIATE_DIR)/libraries.cc'],
           'action': [
             'python',
             '../../tools/js2c.py',
             '<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
             'CORE',
             '<@(library_files)',
-            '<@(i18n_library_files)'
           ],
         },
         {
           'action_name': 'js2c_bin',
           'inputs': [
             '../../tools/js2c.py',
             '<@(library_files)',
-            '<@(i18n_library_files)'
           ],
           'outputs': ['<@(libraries_bin_file)'],
           'action': [
             'python',
             '../../tools/js2c.py',
             '<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
             'CORE',
             '<@(library_files)',
-            '<@(i18n_library_files)',
             '--startup_blob', '<@(libraries_bin_file)',
             '--nojs',
           ],
         },
         {
           'action_name': 'js2c_experimental',
           'inputs': [
             '../../tools/js2c.py',
             '<@(experimental_library_files)',
           ],
@@ skipping 138 matching lines @@
         }],
         ['want_separate_host_toolset==1', {
           'toolsets': ['host'],
         }, {
           'toolsets': ['target'],
         }],
       ],
     },
   ],
 }