Use ICU case conversion/transliterator for case conversion behind a flag

test/intl/testcfg.py

 # Copyright 2013 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 36 matching lines @@
         if (filename.endswith(".js") and filename != "assert.js" and
             filename != "utils.js"):
           fullpath = os.path.join(dirname, filename)
           relpath = fullpath[len(self.root) + 1 : -3]
           testname = relpath.replace(os.path.sep, "/")
           test = testcase.TestCase(self, testname)
           tests.append(test)
     return tests
 
   def GetFlagsForTestCase(self, testcase, context):
-    flags = ["--allow-natives-syntax"] + context.mode_flags
+    flags = ["--allow-natives-syntax", "--icu-case-mapping"] + \

[Dan Ehrenberg, 2016/03/17 20:38:36]

BTW other testcfg.py's have support for a // Flags: line at the beginning of the
file, which is probably the better way to do this.

[jungshik at Google, 2016/04/08 18:09:33]

I'm not sure what you meant.  

$  find . -name testcfg.py | xargs grep Flags

does not turn up anything like that. 

[Dan Ehrenberg, 2016/04/08 21:13:46]

No, Flags is used in test cases, but implemented in testcfg.py. An example of a
test using flags is

test/mjsunit/es6/arguments-iterator.js

which has the line 

// Flags: --allow-natives-syntax 

In test/mjsunit/testcfg.py, this is supported by the code in
GetFlagsForTestCase. This could be copy-pasted into intl/testcfg.py, or the
tests could be moved to mjsunit (why are they separated out in the first place?
is it just historical?).

+        context.mode_flags
 
     files = []
     files.append(os.path.join(self.root, "assert.js"))
     files.append(os.path.join(self.root, "utils.js"))
     files.append(os.path.join(self.root, testcase.path + self.suffix()))
 
     flags += files
     if context.isolates:
       flags.append("--isolate")
       flags += files
 
     return testcase.flags + flags
 
 
 def GetSuite(name, root):
   return IntlTestSuite(name, root)