Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: test/intl/testcfg.py

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Yang's comment addressed - return right away for no-change Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
11 # with the distribution. 11 # with the distribution.
12 # * Neither the name of Google Inc. nor the names of its 12 # * Neither the name of Google Inc. nor the names of its
13 # contributors may be used to endorse or promote products derived 13 # contributors may be used to endorse or promote products derived
14 # from this software without specific prior written permission. 14 # from this software without specific prior written permission.
15 # 15 #
16 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 import os 28 import os
29 import re
29 30
30 from testrunner.local import testsuite 31 from testrunner.local import testsuite
31 from testrunner.objects import testcase 32 from testrunner.objects import testcase
32 33
34 FLAGS_PATTERN = re.compile(r"//\s+Flags:(.*)")
33 35
34 class IntlTestSuite(testsuite.TestSuite): 36 class IntlTestSuite(testsuite.TestSuite):
35 37
36 def __init__(self, name, root): 38 def __init__(self, name, root):
37 super(IntlTestSuite, self).__init__(name, root) 39 super(IntlTestSuite, self).__init__(name, root)
38 40
39 def ListTests(self, context): 41 def ListTests(self, context):
40 tests = [] 42 tests = []
41 for dirname, dirs, files in os.walk(self.root): 43 for dirname, dirs, files in os.walk(self.root):
42 for dotted in [x for x in dirs if x.startswith('.')]: 44 for dotted in [x for x in dirs if x.startswith('.')]:
43 dirs.remove(dotted) 45 dirs.remove(dotted)
44 dirs.sort() 46 dirs.sort()
45 files.sort() 47 files.sort()
46 for filename in files: 48 for filename in files:
47 if (filename.endswith(".js") and filename != "assert.js" and 49 if (filename.endswith(".js") and filename != "assert.js" and
48 filename != "utils.js" and filename != "regexp-assert.js" and 50 filename != "utils.js" and filename != "regexp-assert.js" and
49 filename != "regexp-prepare.js"): 51 filename != "regexp-prepare.js"):
50 fullpath = os.path.join(dirname, filename) 52 fullpath = os.path.join(dirname, filename)
51 relpath = fullpath[len(self.root) + 1 : -3] 53 relpath = fullpath[len(self.root) + 1 : -3]
52 testname = relpath.replace(os.path.sep, "/") 54 testname = relpath.replace(os.path.sep, "/")
53 test = testcase.TestCase(self, testname) 55 test = testcase.TestCase(self, testname)
54 tests.append(test) 56 tests.append(test)
55 return tests 57 return tests
56 58
57 def GetFlagsForTestCase(self, testcase, context): 59 def GetFlagsForTestCase(self, testcase, context):
60 source = self.GetSourceForTest(testcase)
58 flags = ["--allow-natives-syntax"] + context.mode_flags 61 flags = ["--allow-natives-syntax"] + context.mode_flags
62 flags_match = re.findall(FLAGS_PATTERN, source)
63 for match in flags_match:
64 flags += match.strip().split()
59 65
60 files = [] 66 files = []
61 files.append(os.path.join(self.root, "assert.js")) 67 files.append(os.path.join(self.root, "assert.js"))
62 files.append(os.path.join(self.root, "utils.js")) 68 files.append(os.path.join(self.root, "utils.js"))
63 files.append(os.path.join(self.root, "regexp-prepare.js")) 69 files.append(os.path.join(self.root, "regexp-prepare.js"))
64 files.append(os.path.join(self.root, testcase.path + self.suffix())) 70 files.append(os.path.join(self.root, testcase.path + self.suffix()))
65 files.append(os.path.join(self.root, "regexp-assert.js")) 71 files.append(os.path.join(self.root, "regexp-assert.js"))
66 72
67 flags += files 73 flags += files
68 if context.isolates: 74 if context.isolates:
69 flags.append("--isolate") 75 flags.append("--isolate")
70 flags += files 76 flags += files
71 77
72 return testcase.flags + flags 78 return testcase.flags + flags
73 79
80 def GetSourceForTest(self, testcase):
81 filename = os.path.join(self.root, testcase.path + self.suffix())
82 with open(filename) as f:
83 return f.read()
74 84
75 def GetSuite(name, root): 85 def GetSuite(name, root):
76 return IntlTestSuite(name, root) 86 return IntlTestSuite(name, root)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698