Chromium Code Reviews Chromium Code Reviews
Issue 1812673005:
Use ICU case conversion/transliterator for case conversion behind a flag (Closed)
Base URL: https://chromium.googlesource.com/v8/v8.git@master| OLD | NEW |
|---|---|
| 1 # Copyright 2013 the V8 project authors. All rights reserved. | 1 # Copyright 2013 the V8 project authors. All rights reserved. |
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without |
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are |
| 4 # met: | 4 # met: |
| 5 # | 5 # |
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright |
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. |
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above |
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following |
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided |
| (...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 48 filename != "utils.js" and filename != "regexp-assert.js" and | 48 filename != "utils.js" and filename != "regexp-assert.js" and |
| 49 filename != "regexp-prepare.js"): | 49 filename != "regexp-prepare.js"): |
| 50 fullpath = os.path.join(dirname, filename) | 50 fullpath = os.path.join(dirname, filename) |
| 51 relpath = fullpath[len(self.root) + 1 : -3] | 51 relpath = fullpath[len(self.root) + 1 : -3] |
| 52 testname = relpath.replace(os.path.sep, "/") | 52 testname = relpath.replace(os.path.sep, "/") |
| 53 test = testcase.TestCase(self, testname) | 53 test = testcase.TestCase(self, testname) |
| 54 tests.append(test) | 54 tests.append(test) |
| 55 return tests | 55 return tests |
| 56 | 56 |
| 57 def GetFlagsForTestCase(self, testcase, context): | 57 def GetFlagsForTestCase(self, testcase, context): |
| 58 flags = ["--allow-natives-syntax"] + context.mode_flags | 58 flags = ["--allow_natives_syntax"] + context.mode_flags |
|
Dan Ehrenberg
2016/05/05 23:36:57
Nit: No need for this change.
jungshik at Google
2016/05/06 21:51:18
Done.
| |
| 59 | 59 |
| 60 files = [] | 60 files = [] |
| 61 files.append(os.path.join(self.root, "assert.js")) | 61 files.append(os.path.join(self.root, "assert.js")) |
| 62 files.append(os.path.join(self.root, "utils.js")) | 62 files.append(os.path.join(self.root, "utils.js")) |
| 63 files.append(os.path.join(self.root, "regexp-prepare.js")) | 63 files.append(os.path.join(self.root, "regexp-prepare.js")) |
| 64 files.append(os.path.join(self.root, testcase.path + self.suffix())) | 64 files.append(os.path.join(self.root, testcase.path + self.suffix())) |
| 65 files.append(os.path.join(self.root, "regexp-assert.js")) | 65 files.append(os.path.join(self.root, "regexp-assert.js")) |
| 66 | 66 |
| 67 flags += files | 67 flags += files |
| 68 if context.isolates: | 68 if context.isolates: |
| 69 flags.append("--isolate") | 69 flags.append("--isolate") |
| 70 flags += files | 70 flags += files |
| 71 | 71 |
| 72 return testcase.flags + flags | 72 return testcase.flags + flags |
| 73 | 73 |
| 74 | 74 |
| 75 def GetSuite(name, root): | 75 def GetSuite(name, root): |
| 76 return IntlTestSuite(name, root) | 76 return IntlTestSuite(name, root) |
| OLD | NEW |
