third_party/WebKit/Source/web/WebInputEventConversion.cpp - Issue 1812653002: Scale the deltaX/deltaY on the mouse wheel events to be consistent with the compositor implementati…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebInputEventConversion.cpp

Issue 1812653002: Scale the deltaX/deltaY on the mouse wheel events to be consistent with the compositor implementati… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add another layout test that was failing Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html ('K') | « third_party/WebKit/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebInputEventConversion.cpp

diff --git a/third_party/WebKit/Source/web/WebInputEventConversion.cpp b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

index 1ae6a4ae6f46d48d7eda647a1343940cf942d1df..946fd9dbeb680934bf9e6ecda7f32ff67b920722 100644

--- a/third_party/WebKit/Source/web/WebInputEventConversion.cpp

+++ b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

@@ -153,8 +153,8 @@ PlatformWheelEventBuilder::PlatformWheelEventBuilder(Widget* widget, const WebMo

{

m_position = widget->convertFromRootFrame(flooredIntPoint(convertHitPointToRootFrame(widget, FloatPoint(e.x, e.y))));

m_globalPosition = IntPoint(e.globalX, e.globalY);

- m_deltaX = e.deltaX;

- m_deltaY = e.deltaY;

+ m_deltaX = scaleDeltaToWindow(widget, e.deltaX);

+ m_deltaY = scaleDeltaToWindow(widget, e.deltaY);

m_wheelTicksX = e.wheelTicksX;

m_wheelTicksY = e.wheelTicksY;

m_granularity = e.scrollByPage ?