Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1812653002: Scale the deltaX/deltaY on the mouse wheel events to be consistent with the compositor implementati… (Closed)

Created:
4 years, 9 months ago by dtapuska
Modified:
4 years, 9 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, ymalik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scale the deltaX/deltaY on the mouse wheel events to be consistent with the compositor implementation. As the page is zoomed in the scroll amount shouldn't increase. This issue was discovered with the conversion to mouse wheel gestures which uses gesture scrolls which are scaled; and the layout test was failing for those cases. BUG=595441 Committed: https://crrev.com/aa27c866cdef570e9788f9a93a3a3d87aa36ebce Cr-Commit-Position: refs/heads/master@{#381702}

Patch Set 1 #

Patch Set 2 : Add another layout test that was failing #

Total comments: 2

Patch Set 3 : Remove unnecessary arguments from call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dtapuska
4 years, 9 months ago (2016-03-16 21:42:23 UTC) #3
bokan
lgtm https://codereview.chromium.org/1812653002/diff/20001/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html File third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html (right): https://codereview.chromium.org/1812653002/diff/20001/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html#newcode9 third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html:9: eventSender.continuousMouseScrollBy(0, -2, false, true); Why do we need ...
4 years, 9 months ago (2016-03-17 12:31:16 UTC) #4
dtapuska
https://codereview.chromium.org/1812653002/diff/20001/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html File third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html (right): https://codereview.chromium.org/1812653002/diff/20001/third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html#newcode9 third_party/WebKit/LayoutTests/fast/events/gesture-pinch-zoom-scroll-bubble.html:9: eventSender.continuousMouseScrollBy(0, -2, false, true); On 2016/03/17 12:31:16, bokan wrote: ...
4 years, 9 months ago (2016-03-17 12:48:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812653002/40001
4 years, 9 months ago (2016-03-17 12:48:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 13:59:35 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 14:00:57 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aa27c866cdef570e9788f9a93a3a3d87aa36ebce
Cr-Commit-Position: refs/heads/master@{#381702}

Powered by Google App Engine
This is Rietveld 408576698