Issue 1812633002: No longer limit QUIC's max CWND to 200 packets. Protected by quic_dont_limit_max_cwnd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1812633002: No longer limit QUIC's max CWND to 200 packets. Protected by quic_dont_limit_max_cwnd. (Closed)

Created:
4 years, 9 months ago by fnk

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@116768420

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

No longer limit QUIC's max CWND to 200 packets. Protected by quic_dont_limit_max_cwnd. This is a fix for the deprecation of a similar flag in cr/113769379. Merge internal change: 116794514 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -3 lines)			Patch
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+5 lines, -2 lines	1 comment	Download
M	net/quic/quic_sent_packet_manager.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1805323003 Patch 1

Dependent Patchsets:

Issue 1807033002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 9 months ago (2016-03-16 20:29:21 UTC) #2

lgtm

https://codereview.chromium.org/1812633002/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/1812633002/diff/1/net/quic/quic_flags.cc#newc...
net/quic/quic_flags.cc:140: bool FLAGS_quic_enable_rto_timeout = true;
Ah, now they're true :>

Expand Messages | Collapse Messages