Enable building pdf_use_skia in the standalone build.

Enable building pdf_use_skia in the standalone build.

This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.

R=caryclark@google.com

Committed: https://pdfium.googlesource.com/pdfium/+/a03c343b47938fcb1b562741ff05252b01a4e39d

[dsinclair, 2016-03-16 17:30:08]

dsinclair@chromium.org changed reviewers:
+ caryclark@chromium.org, tsepez@chromium.org

[dsinclair, 2016-03-16 17:30:09]

PTAL.

I copied some stuff from chromium/ to make this work. I left the copyright as I
wasn't sure if it should be updated or not.

I had to do some hackery to make it build without fontconfig, but running
hello_world.pdf to generate a skp and then opening it in the skia_debugger
worked correctly.

[caryclark, 2016-03-16 17:40:17]

caryclark@google.com changed reviewers:
+ caryclark@google.com

[caryclark, 2016-03-16 17:40:18]

lgtm

I'll learn more by using it than by looking for errors (if there are any) in
this check-in, so I'll try patching and running in parallel

https://codereview.chromium.org/1812563002/diff/1/core/fxge/skia/fx_skia_devi...
File core/fxge/skia/fx_skia_device.h (right):

https://codereview.chromium.org/1812563002/diff/1/core/fxge/skia/fx_skia_devi...
core/fxge/skia/fx_skia_device.h:45: override;  // graphic state, for pen
attributes
comment sticks to parameter?

[Tom Sepez, 2016-03-16 18:51:51]

Is there a way to avoid confusion between /third_party/skia and /skia
directories?  Must these be named the same, or could the non-third_party/ one be
called skia_adapter/ or some such if it makes sense?

Do all three of the top-level libraries (core, fpdfsdk, xfa) call into
skia_adapter/ code? or is it just fxge/ ? If the later, can this live under fxge
(as does agg at the moment)?

Otherwise, its fine as far as I can tell.

https://codereview.chromium.org/1812563002/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1812563002/diff/1/.gitignore#newcode29
.gitignore:29: third_party/skia
nit: keep sorted, this goes at line 11.  Is there a leading /, too?

https://codereview.chromium.org/1812563002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1812563002/diff/1/DEPS#newcode4
DEPS:4: 'chromium_git': 'https://chromium.googlesource.com',
As long as you are going to introduce vars, would you be kind enough to update
all of the code below to use an expression like at line 17?

https://codereview.chromium.org/1812563002/diff/1/DEPS#newcode16
DEPS:16: "third_party/skia":
alphabetize, move to line 28

[dsinclair, 2016-03-16 19:35:03]

On 2016/03/16 18:51:51, Tom Sepez wrote:
> Is there a way to avoid confusion between /third_party/skia and /skia
> directories?  Must these be named the same, or could the non-third_party/ one
be
> called skia_adapter/ or some such if it makes sense?
> 
> Do all three of the top-level libraries (core, fpdfsdk, xfa) call into
> skia_adapter/ code? or is it just fxge/ ? If the later, can this live under
fxge
> (as does agg at the moment)?
> 
> Otherwise, its fine as far as I can tell.
> 

The real skia code lives in third_party/skia which is where I think it belongs.
We should not make any modifications to this code, they should happen upstream,
so it's strictly third_party. The pdfium/skia/ folder contains .gyp (and a
single .cc to define a needed logging method). This is done so we match how
chromium does it's build.

[dsinclair, 2016-03-16 19:35:14]

https://codereview.chromium.org/1812563002/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/1812563002/diff/1/.gitignore#newcode29
.gitignore:29: third_party/skia
On 2016/03/16 18:51:51, Tom Sepez wrote:
> nit: keep sorted, this goes at line 11.  Is there a leading /, too?

Done.

https://codereview.chromium.org/1812563002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1812563002/diff/1/DEPS#newcode4
DEPS:4: 'chromium_git': 'https://chromium.googlesource.com',
On 2016/03/16 18:51:51, Tom Sepez wrote:
> As long as you are going to introduce vars, would you be kind enough to update
> all of the code below to use an expression like at line 17?

Done.

https://codereview.chromium.org/1812563002/diff/1/DEPS#newcode16
DEPS:16: "third_party/skia":
On 2016/03/16 18:51:51, Tom Sepez wrote:
> alphabetize, move to line 28

Apparently I can't spell.

https://codereview.chromium.org/1812563002/diff/1/core/fxge/skia/fx_skia_devi...
File core/fxge/skia/fx_skia_device.h (right):

https://codereview.chromium.org/1812563002/diff/1/core/fxge/skia/fx_skia_devi...
core/fxge/skia/fx_skia_device.h:45: override;  // graphic state, for pen
attributes
On 2016/03/16 17:40:18, caryclark wrote:
> comment sticks to parameter?

Done.

[dsinclair, 2016-03-16 19:35:25]

Description was changed from

==========
Enable building pdf_use_skia in the standalone build.

This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.
==========

to

==========
Enable building pdf_use_skia in the standalone build.

This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.

R=caryclark@google.com

Committed:
https://pdfium.googlesource.com/pdfium/+/a03c343b47938fcb1b562741ff05252b01a4...
==========

[dsinclair, 2016-03-16 19:35:26]

Committed patchset #2 (id:20001) manually as
a03c343b47938fcb1b562741ff05252b01a4e39d (presubmit successful).