Chromium Code Reviews
DescriptionReland of Fix accessible focus state on menu bar container. (patchset #1 id:1 of https://codereview.chromium.org/1806943002/ )
Reason for revert:
Tests still fail so I'm relanding.
Original issue's description:
> Revert of Fix accessible focus state on menu bar container. (patchset #1 id:1 of https://codereview.chromium.org/1801183002/ )
>
> Reason for revert:
> I'm speculatively reverting this cl since webkit tests started failing on Windows. See here for example:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/4939
>
> webkit_tests webkit_tests
> unexpected_failures:
> virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance.html
> virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html
> virtual/scalefactor150/fast/hidpi/static/popup-menu-appearance.html
>
> Original issue's description:
> > Fix accessible focus state on menu bar container.
> >
> > When the Chrome menu is open, we use a role of "menu bar" for the outer
> > pop-up container, "menu" inside of that, and "menu item" for each item.
> > One screen reader, NVDA, ignores focus events inside the menu unless the
> > menu bar indicates that it's focused.
> >
> > This code was moved from cross-platform code to Windows-specific code in
> > r376339 when we switched to keeping track of focus globally, but
> > unfortunately it broke because we don't keep track of focus inside
> > the menu pop-up.
> >
> > So for now as a quick fix, just mark the menu bar role as focused when
> > visible. This will work fine because this is the only place we use the
> > menu bar role and it's only visible when the menu is popped up. Later
> > a better fix would be to properly track focus inside the menu pop-up.
> >
> > Tested manually with NVDA.
> >
> > BUG=593589
> >
> > Committed: https://crrev.com/34bf4c64e98f95f62d37891f45a945076c506a56
> > Cr-Commit-Position: refs/heads/master@{#381320}
>
> TBR=nektar@chromium.org,dmazzoni@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=593589
>
> Committed: https://crrev.com/02f4658071ca4d361e107f81bf397ac2a2f234df
> Cr-Commit-Position: refs/heads/master@{#381469}
TBR=nektar@chromium.org,dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593589
Committed: https://crrev.com/f639831519bf5dd7bfc1437d87864a7137e81a29
Cr-Commit-Position: refs/heads/master@{#381483}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||