Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: media/base/media_tracks.h

Issue 1812543003: Allow muting/unmuting audio through media track API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-sb-tracks6
Patch Set: Added VideoTrackSelectDeselect test case Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/media_tracks.h
diff --git a/media/base/media_tracks.h b/media/base/media_tracks.h
index 4e0fbb0fc1f88195ce14cc05d14a424924be4d5d..65cf0362a4b5251c2e1c12830c88048e43c447b4 100644
--- a/media/base/media_tracks.h
+++ b/media/base/media_tracks.h
@@ -17,30 +17,38 @@
namespace media {
class AudioDecoderConfig;
+class DemuxerStream;
class VideoDecoderConfig;
class MEDIA_EXPORT MediaTracks {
public:
typedef std::vector<scoped_ptr<MediaTrack>> MediaTracksCollection;
+ typedef std::map<const MediaTrack*, const DemuxerStream*>
+ TrackToDemuxStreamMap;
MediaTracks();
~MediaTracks();
// Callers need to ensure that track id is unique.
- void AddAudioTrack(const AudioDecoderConfig& config,
- const std::string& id,
- const std::string& kind,
- const std::string& label,
- const std::string& language);
+ const MediaTrack* AddAudioTrack(const AudioDecoderConfig& config,
+ const std::string& id,
+ const std::string& kind,
+ const std::string& label,
+ const std::string& language);
// Callers need to ensure that track id is unique.
- void AddVideoTrack(const VideoDecoderConfig& config,
- const std::string& id,
- const std::string& kind,
- const std::string& label,
- const std::string& language);
+ const MediaTrack* AddVideoTrack(const VideoDecoderConfig& config,
+ const std::string& id,
+ const std::string& kind,
+ const std::string& label,
+ const std::string& language);
const MediaTracksCollection& tracks() const { return tracks_; }
+ const TrackToDemuxStreamMap& track_to_demux_stream_map() const {
+ return track_to_demux_stream_map_;
+ }
+ void set_track_to_demux_stream_map(const TrackToDemuxStreamMap& m);
wolenetz 2016/04/08 23:32:31 Hmm. Is this for testing only? It seems a bit extr
servolk 2016/04/08 23:47:20 No. This needs to be called before reporting media
wolenetz 2016/04/14 20:43:39 I see. Since MediaTracks effectively owns the map,
servolk 2016/04/15 02:23:24 Ok, I've refactored this code a bit, to make it si
servolk 2016/04/15 02:32:59 To expand a bit on this: I think we probably don't
+
const AudioDecoderConfig& getAudioConfig(const std::string& id) const;
const VideoDecoderConfig& getVideoConfig(const std::string& id) const;
@@ -51,6 +59,7 @@ class MEDIA_EXPORT MediaTracks {
private:
MediaTracksCollection tracks_;
+ TrackToDemuxStreamMap track_to_demux_stream_map_;
std::map<std::string, AudioDecoderConfig> audio_configs_;
std::map<std::string, VideoDecoderConfig> video_configs_;

Powered by Google App Engine
This is Rietveld 408576698