Allow muting/unmuting audio through media track API

media/base/media_tracks.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/media_tracks.h"
 
 #include "base/bind.h"
 #include "media/base/audio_decoder_config.h"
 #include "media/base/video_decoder_config.h"
 
 namespace media {
 
 MediaTracks::MediaTracks() {}
 
 MediaTracks::~MediaTracks() {}
 
-void MediaTracks::AddAudioTrack(const AudioDecoderConfig& config,
-                                const std::string& id,
-                                const std::string& kind,
-                                const std::string& label,
-                                const std::string& language) {
+const MediaTrack* MediaTracks::AddAudioTrack(const AudioDecoderConfig& config,
+                                             const std::string& id,
+                                             const std::string& kind,
+                                             const std::string& label,
+                                             const std::string& language) {
   DCHECK(config.IsValidConfig());
   CHECK(audio_configs_.find(id) == audio_configs_.end());
   scoped_ptr<MediaTrack> track = make_scoped_ptr(
       new MediaTrack(MediaTrack::Audio, id, kind, label, language));
   tracks_.push_back(std::move(track));
   audio_configs_[id] = config;
+  return tracks_.back().get();
 }
 
-void MediaTracks::AddVideoTrack(const VideoDecoderConfig& config,
-                                const std::string& id,
-                                const std::string& kind,
-                                const std::string& label,
-                                const std::string& language) {
+const MediaTrack* MediaTracks::AddVideoTrack(const VideoDecoderConfig& config,
+                                             const std::string& id,
+                                             const std::string& kind,
+                                             const std::string& label,
+                                             const std::string& language) {
   DCHECK(config.IsValidConfig());
   CHECK(video_configs_.find(id) == video_configs_.end());
   scoped_ptr<MediaTrack> track = make_scoped_ptr(
       new MediaTrack(MediaTrack::Video, id, kind, label, language));
   tracks_.push_back(std::move(track));
   video_configs_[id] = config;
+  return tracks_.back().get();
+}
+
+void MediaTracks::SetDemuxerStreamForMediaTrack(const MediaTrack* track,
+                                                const DemuxerStream* stream) {
+  DCHECK(track_to_demux_stream_map_.find(track) ==
+         track_to_demux_stream_map_.end());
+  track_to_demux_stream_map_[track] = stream;

[wolenetz, 2016/04/15 22:47:18]

Please add a CHECK that |tracks_| contains |track|. Otherwise, bad things easily
done by caller could go uncaught here. See also comment, below.

[servolk, 2016/04/15 23:26:31]

Done.

+}
+
+MediaTracks::TrackIdToDemuxStreamMap MediaTracks::OnTrackIdsAssigned(
+    const std::vector<unsigned>& track_ids) const {
+  TrackIdToDemuxStreamMap result;
+  CHECK_EQ(tracks().size(), track_ids.size());
+  CHECK_EQ(track_to_demux_stream_map_.size(), tracks().size());
+  for (size_t i = 0; i < track_ids.size(); ++i) {
+    const MediaTrack* track = tracks()[i].get();
+    DCHECK(track);
+    const auto& it = track_to_demux_stream_map_.find(track);
+    DCHECK(it != track_to_demux_stream_map_.end());

[wolenetz, 2016/04/15 22:47:18]

If SetDemuxerStreamForMediaTrack() hasn't been called for this particular track,
but maybe someone mistakenly sent some other rogue pointer to
SetDemuxerStreamForMediaTrack(), then in a release build, it->second, below,
could be bad. Pleas es/DCHECK/CHECK/ here, and also protect (also in release
builds) in SetDemuxerStreamForMediaTrack() that caller provides a valid |track|
that's in our tracks() already.

[servolk, 2016/04/15 23:26:31]

Done.

+    DVLOG(3) << "OnTrackIdsAssigned track_id=" << track_ids[i]
+             << " DemuxerStream=" << it->second;
+    result[track_ids[i]] = it->second;
+  }
+  return result;
 }
 
 const AudioDecoderConfig& MediaTracks::getAudioConfig(
     const std::string& id) const {
   auto it = audio_configs_.find(id);
   if (it != audio_configs_.end())
     return it->second;
   static AudioDecoderConfig invalidConfig;
   return invalidConfig;
 }
@@ skipping 21 matching lines @@
   for (const auto& track : tracks()) {
     if (track->type() == MediaTrack::Video) {
       return getVideoConfig(track->id());
     }
   }
   static VideoDecoderConfig invalidConfig;
   return invalidConfig;
 }
 
 }  // namespace media