Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1812543002: For desktop tab sharing in mac, activate selected tab (Closed)

Created:
4 years, 9 months ago by GeorgeZ
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

For desktop tab sharing in mac, activate selected tab This CL mimics the code for desktop platforms other than mac in https://codereview.chromium.org/1805583002/ BUG=594722 Committed: https://crrev.com/67d45bc3c87f99d13559ed6623fe4c674642330e Cr-Commit-Position: refs/heads/master@{#381491}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
GeorgeZ
Avi, Could you please take a look of this CL? Thanks,
4 years, 9 months ago (2016-03-16 16:59:26 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-16 17:04:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812543002/1
4 years, 9 months ago (2016-03-16 17:07:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 17:56:45 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:58:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67d45bc3c87f99d13559ed6623fe4c674642330e
Cr-Commit-Position: refs/heads/master@{#381491}

Powered by Google App Engine
This is Rietveld 408576698