Downgrade page security if an inline has invalid certificate.

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 195edc388d7e714b3c4772930b2b099f260654fa..af70e0f67e956e854d4cc0496b94c5cc3befda98 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1881,6 +1881,10 @@ void WebContentsImpl::DragSourceMovedTo(int client_x, int client_y,
 
 void WebContentsImpl::DidGetResourceResponseStart(
   const ResourceRequestDetails& details) {
+
+  if (net::IsCertStatusError(details.ssl_cert_status))
+    displayed_insecure_content_ = true;

[Charlie Reis, 2014/04/09 17:20:17]

I think the main thing that confused me was that it's not clear the appropriate
notifications will be sent in DidStartResourceResponse (and same in the case
below), and thus we don't need to call OnDidDisplayInsecureContent.

Can you add a comment to that effect both here and in
OnDidLoadResourceFromMemoryCache?

+
   controller_.ssl_manager()->DidStartResourceResponse(details);
 
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,
@@ -2272,6 +2276,9 @@ void WebContentsImpl::OnDidLoadResourceFromMemoryCache(
       url, GetRenderProcessHost()->GetID(), cert_id, cert_status, http_method,
       mime_type, resource_type);
 
+  if (net::IsCertStatusError(cert_status))
+    displayed_insecure_content_ = true;
+
   controller_.ssl_manager()->DidLoadFromMemoryCache(details);
 
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,