Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 181253003: Downgrade page security if an inline has invalid certificate. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review follow up: added browser test. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index b75d8bab31dbb7b4395ebf787e18656892c0dcf0..e68ed92e4245ac827b3ab6b5a37ad161ed20dde5 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1806,6 +1806,9 @@ void WebContentsImpl::DragSourceMovedTo(int client_x, int client_y,
void WebContentsImpl::DidGetResourceResponseStart(
const ResourceRequestDetails& details) {
+ if (net::IsCertStatusError(details.ssl_cert_status)) {
+ displayed_insecure_content_ = true;
+ }
Ryan Sleevi 2014/03/21 20:22:54 style nit: Throughout this file, it seems like it
controller_.ssl_manager()->DidStartResourceResponse(details);
FOR_EACH_OBSERVER(WebContentsObserver, observers_,
@@ -2086,6 +2089,9 @@ void WebContentsImpl::OnDidLoadResourceFromMemoryCache(
url, GetRenderProcessHost()->GetID(), cert_id, cert_status, http_method,
mime_type, resource_type);
+ if (net::IsCertStatusError(cert_status)) {
+ displayed_insecure_content_ = true;
+ }
controller_.ssl_manager()->DidLoadFromMemoryCache(details);
FOR_EACH_OBSERVER(WebContentsObserver, observers_,

Powered by Google App Engine
This is Rietveld 408576698