Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 181253002: A64: Make the Decoder a template (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Make the Decoder a template This will allow for replacing the dispatcher with a concrete decoder visitor. BUG=none R=ulan@chromium.org, rodolph.perfetta@arm.com LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -826 lines) Patch
M src/a64/debugger-a64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/a64/decoder-a64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/a64/decoder-a64.cc View 1 chunk +0 lines, -618 lines 0 comments Download
A + src/a64/decoder-a64-inl.h View 23 chunks +121 lines, -177 lines 0 comments Download
M src/a64/disasm-a64.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/a64/simulator-a64.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/a64/simulator-a64.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-a64.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/test-disasm-a64.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M test/cctest/test-fuzz-a64.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-26 08:51:35 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-26 11:03:34 UTC) #2
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-26 12:01:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19562 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698