Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1812523004: [MD settings] rename Search engine settings to Search engine (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] rename Search engine settings to Search engine Alan felt that just the word 'Search' made the side nav look like it was an option to search inside settings. He asked that the section name be changed to 'Search engine'. BUG=589630 Committed: https://crrev.com/0babd466532f187f231ff8a8ea6b95c7cc190251 Cr-Commit-Position: refs/heads/master@{#381782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/settings_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 9 months ago (2016-03-17 19:01:41 UTC) #2
tommycli
lgtm
4 years, 9 months ago (2016-03-17 19:21:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812523004/1
4 years, 9 months ago (2016-03-17 19:26:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 20:02:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 20:03:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0babd466532f187f231ff8a8ea6b95c7cc190251
Cr-Commit-Position: refs/heads/master@{#381782}

Powered by Google App Engine
This is Rietveld 408576698