Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1812523003: Add mach ports support to the Mojo shell. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-mach-ports
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mach ports support to the Mojo shell. BUG=582468 Committed: https://crrev.com/6bebadddb399ad1c1f91592efed410040617e708 Cr-Commit-Position: refs/heads/master@{#382335}

Patch Set 1 #

Patch Set 2 : Try fix build. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -1 line) Patch
M mojo/mojo_shell.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/shell/runner/host/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/shell/runner/host/child_process.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
A mojo/shell/runner/host/mach_broker.h View 1 chunk +54 lines, -0 lines 0 comments Download
A mojo/shell/runner/host/mach_broker.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M mojo/shell/standalone/context.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
Anand Mistry (off Chromium)
Who else should I send this to (shell owners)?
4 years, 9 months ago (2016-03-19 01:10:53 UTC) #2
Ken Rockot(use gerrit already)
Lgtm, I'd say Ben for owners
4 years, 9 months ago (2016-03-19 01:27:06 UTC) #3
Anand Mistry (off Chromium)
Ben: Can you take a look as a shell owner?
4 years, 9 months ago (2016-03-19 01:32:19 UTC) #5
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-19 02:50:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812523003/20001
4 years, 9 months ago (2016-03-21 16:58:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/7114) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-21 17:00:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812523003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812523003/40001
4 years, 9 months ago (2016-03-21 17:20:51 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-21 18:32:55 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:34:05 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6bebadddb399ad1c1f91592efed410040617e708
Cr-Commit-Position: refs/heads/master@{#382335}

Powered by Google App Engine
This is Rietveld 408576698