Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7754)

Unified Diff: chrome/test/data/extensions/api_test/service_worker/sync/page.js

Issue 1812503002: Fix race in ServiceWorkerBackgroundSyncTest.Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Verify messages Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/service_worker/sync/sw.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/service_worker/sync/page.js
diff --git a/chrome/test/data/extensions/api_test/service_worker/sync/page.js b/chrome/test/data/extensions/api_test/service_worker/sync/page.js
index 9bac72b2f8dd0f68ad461f5e8f1479417907297b..57febfd8d0bd61e8dd7475207661f6b8e5faeba7 100644
--- a/chrome/test/data/extensions/api_test/service_worker/sync/page.js
+++ b/chrome/test/data/extensions/api_test/service_worker/sync/page.js
@@ -22,6 +22,10 @@ window.runServiceWorker = function() {
var mc = new MessageChannel();
// Called when ServiceWorker.onsync fires.
mc.port1.onmessage = function(e) {
+ if (e.data == 'connected') {
+ window.domAutomationController.send('SERVICE_WORKER_READY');
+ return;
+ }
if (e.data != 'SYNC: send-chats') {
console.log('SW returned incorrect data: ' + e.data);
chrome.test.sendMessage('FAIL'); // Fails the test fast.
@@ -30,7 +34,6 @@ window.runServiceWorker = function() {
chrome.test.sendMessage(e.data);
};
serviceWorker.postMessage('connect', [mc.port2]);
- window.domAutomationController.send('SERVICE_WORKER_READY');
}).catch(function(err) {
window.domAutomationController.send(err);
});
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/service_worker/sync/sw.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698