Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1812493002: If add 'id' on pending SVG resource references does not work for non-resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 932fc61b351b72c8d8201a7722d290e6bc75fd5b..ffc4f891f7dad39a8e2cde1c2b2b1bb13b511552 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -143,10 +143,13 @@ void SVGElement::buildPendingResourcesIfNeeded()
// FIXME: Ideally we'd always resolve pending resources async instead of inside
// insertedInto and svgAttributeChanged. For now we only do it for <use> since
// that would stamp out DOM.
- if (isSVGUseElement(clientElement))
+ if (isSVGUseElement(clientElement)) {
toSVGUseElement(clientElement)->invalidateShadowTree();
- else
+ } else {
clientElement->buildPendingResource();
+ if (LayoutObject* layoutObject = clientElement->layoutObject())
+ markForLayoutAndParentResourceInvalidation(layoutObject);
fs 2016/03/17 17:27:33 I think we usually have invalidation in the specif
hyunjunekim2 2016/03/18 07:44:06 Moved this one to buildPendingResource().
+ }
extensions.clearHasPendingResourcesIfPossible(clientElement);
}
}

Powered by Google App Engine
This is Rietveld 408576698