Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1812463002: MIPS: Fix context loading in CheckAccessGlobalProxy (Closed)

Created:
4 years, 9 months ago by Marija Antic
Modified:
4 years, 9 months ago
Reviewers:
ivica.bogosavljevic, ilija.pavlovic, balazs.kilvady, miran.karic, gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix context loading in CheckAccessGlobalProxy Various failures for MIPS were introduced by the refactoring of the way frames are marked https://codereview.chromium.org/1696043002. Problems were caused during context loading in CheckAccessGlobalProxy * The value of the register at was unintentionally modified. * Use of branch instruction instead of branch macro resulted in a branch instruction in forbidden slot. BUG= Committed: https://crrev.com/b64bcb41b13747a5f7a1a221397990efa1f4fcc4 Cr-Commit-Position: refs/heads/master@{#34829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/mips/macro-assembler-mips.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Marija Antic
4 years, 9 months ago (2016-03-16 14:18:25 UTC) #3
akos.palfi.imgtec
LGTM
4 years, 9 months ago (2016-03-16 15:11:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812463002/1
4 years, 9 months ago (2016-03-16 16:07:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812463002/1
4 years, 9 months ago (2016-03-16 16:08:21 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 16:41:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812463002/1
4 years, 9 months ago (2016-03-16 16:43:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 16:45:32 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 16:46:25 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b64bcb41b13747a5f7a1a221397990efa1f4fcc4
Cr-Commit-Position: refs/heads/master@{#34829}

Powered by Google App Engine
This is Rietveld 408576698