Issue 1812403002: Annotee: Use WithError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1812403002: Annotee: Use WithError. (Closed)

Created:
4 years, 9 months ago by dnj

Modified:
4 years, 9 months ago

Reviewers:
iannucci

CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel

Base URL:
https://github.com/luci/luci-go@master

Target Ref:
refs/heads/master

Project:
luci-go

Visibility:
Public.

More Reviews

Description

Annotee: Use WithError. Forgot to upload this patch set before committing. TBR=iannucci@chromium.org BUG=chromium:595946 TEST=None Committed: https://github.com/luci/luci-go/commit/6ad3ff8e6fc1f72a3c1072bb09e5d80c8a3259b2

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -12 lines)			Patch
	M	client/cmd/logdog_annotee/main.go	View		2 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812403002/1

4 years, 9 months ago (2016-03-18 23:26:09 UTC) #2

commit-bot: I haz the power

4 years, 9 months ago (2016-03-18 23:29:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/6ad3ff8e6fc1f72a3c1072bb09e5d80c8a3259b2

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages