Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 18124002: roll clang 182481:184830 (Closed)

Created:
7 years, 5 months ago by Nico
Modified:
7 years, 5 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, wtc, Alexander Potapenko
Visibility:
Public.

Description

roll clang 182481:184830 New stuff: - can parse gcc 4.7+ headers in gnu++11 mode - -Wheader-guards - -Wlogical-not-parentheses - Fixes http://llvm.org/PR15998 This is also the first time these binaries were built on precise (and as a consequence won't run on lucid). BUG=255201 R=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209703

Patch Set 1 #

Patch Set 2 : reg #

Patch Set 3 : crank #

Patch Set 4 : bla #

Patch Set 5 : ... #

Patch Set 6 : rebase #

Patch Set 7 : android #

Patch Set 8 : cros #

Patch Set 9 : cros2 #

Patch Set 10 : android #

Patch Set 11 : rebase #

Patch Set 12 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
The gyp file changes were reviewed by wtc at https://codereview.chromium.org/17003006/ . The mm file change ...
7 years, 5 months ago (2013-07-02 14:23:08 UTC) #1
hans
lgtm
7 years, 5 months ago (2013-07-02 14:55:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/18124002/68001
7 years, 5 months ago (2013-07-02 14:58:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=13448
7 years, 5 months ago (2013-07-02 15:09:33 UTC) #4
Nico
7 years, 5 months ago (2013-07-02 15:13:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #12 manually as r209703.

Powered by Google App Engine
This is Rietveld 408576698