Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1812383002: Number lines in test-asm-validator from 1. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
Reviewers:
aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Number lines in test-asm-validator from 1. Dropping newlines in the test macros used in test-asm-validator. This will make the tests number from 1, rather than 39, making them easier to read. LOG=N BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=aseemgarg@chromium.org Committed: https://crrev.com/e7f7d2c9438fa6e8db237b31ef04123084d86487 Cr-Commit-Position: refs/heads/master@{#34907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -101 lines) Patch
M test/cctest/test-asm-validator.cc View 48 chunks +96 lines, -101 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bradn
4 years, 9 months ago (2016-03-18 22:52:25 UTC) #2
aseemgarg
lgtm
4 years, 9 months ago (2016-03-18 23:01:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812383002/1
4 years, 9 months ago (2016-03-18 23:02:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812383002/1
4 years, 9 months ago (2016-03-18 23:12:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 23:14:25 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 23:15:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7f7d2c9438fa6e8db237b31ef04123084d86487
Cr-Commit-Position: refs/heads/master@{#34907}

Powered by Google App Engine
This is Rietveld 408576698