Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1812373002: MediaRecorder: ignored disabled audio/video tracks on MR start (Closed)

Created:
4 years, 9 months ago by mcasas
Modified:
4 years, 9 months ago
Reviewers:
Niklas Enbom
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder: ignored disabled audio/video tracks on MR start BUG=596178 Committed: https://crrev.com/f621f87b55831af48c2b184c703500884de3d1fd Cr-Commit-Position: refs/heads/master@{#382253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M content/renderer/media/media_recorder_handler.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mcasas
niklase@ PTAL
4 years, 9 months ago (2016-03-18 23:04:16 UTC) #2
Niklas Enbom
lgtm, test cases for disabled tracks needed as discussed. On 2016/03/18 23:04:16, mcasas wrote: > ...
4 years, 9 months ago (2016-03-18 23:12:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812373002/1
4 years, 9 months ago (2016-03-21 02:19:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/120120)
4 years, 9 months ago (2016-03-21 04:01:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812373002/1
4 years, 9 months ago (2016-03-21 05:36:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 08:05:28 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 08:07:45 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f621f87b55831af48c2b184c703500884de3d1fd
Cr-Commit-Position: refs/heads/master@{#382253}

Powered by Google App Engine
This is Rietveld 408576698