Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 181233013: Fix reference builds on mac. (Closed)

Created:
6 years, 9 months ago by tonyg
Modified:
6 years, 9 months ago
Reviewers:
Ilya Sherman, qyearsley
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 9 months ago (2014-03-06 00:23:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/181233013/1
6 years, 9 months ago (2014-03-06 00:31:07 UTC) #2
tonyg
Committed patchset #1 manually as r255186 (presubmit successful).
6 years, 9 months ago (2014-03-06 01:06:48 UTC) #3
qyearsley
On 2014/03/06 01:06:48, tonyg wrote: > Committed patchset #1 manually as r255186 (presubmit successful). Did ...
6 years, 9 months ago (2014-03-06 01:59:33 UTC) #4
tonyg
6 years, 9 months ago (2014-03-06 02:39:04 UTC) #5
Yes, here was the fix:
http://src.chromium.org/viewvc/chrome?view=revision&revision=255182

No idea what went wrong with the script. I generated that CL by simply
running the script again and then pushing the delta.


On Wed, Mar 5, 2014 at 5:59 PM, <qyearsley@chromium.org> wrote:

> On 2014/03/06 01:06:48, tonyg wrote:
>
>> Committed patchset #1 manually as r255186 (presubmit successful).
>>
>
> Did you find out that some part of the Mac build was not sent properly, or
> had
> the wrong permissions set?
>
> https://codereview.chromium.org/181233013/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698