|
Revert of Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend ( https://codereview.chromium.org/180213008/)
Reason for revert:
Likely broke GCMProfileServiceSingleProfileTest.Unregister Android.
Original issue's description:
> Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend
>
> app_shell needs the chrome.storage.local extension API so the core storage implementation is moving to //extensions/browser/api. However, the "managed storage" API implementation needs to remain in Chrome.
>
> * Introduce ExtensionsApiClient in extensions/browser/api
> * Introduce ChromeExtensionsApiClient in chrome/browser/extensions/api
> * Delegate out the storage ManagedValueStoreCache creation to Chrome
> * Move settings_namespace.h/cc to e/b/api/storage so we can use an enum in the client interface definition
>
> Most APIs will probably need to make only one or two client interface calls, so we're starting with a single ExtensionsApiClient interface. It we find individual APIs tend to need a lot of methods we can split it into one client interface per API, but that seems like overkill right now.
>
> BUG= 348058
> TEST=unit_tests *Settings* and browser_tests ExtensionSettings*
> R=rdevlin.cronin@chromium.org, rockot@chromium.org, yoz@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255069
TBR=rdevlin.cronin@chromium.org,rockot@chromium.org,yoz@chromium.org,jamescook@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 348058
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+101 lines, -268 lines) |
Patch |
 |
M |
apps/shell/browser/shell_extensions_browser_client.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
apps/shell/browser/shell_extensions_browser_client.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/extensions/api/chrome_extensions_api_client.h
|
View
|
|
1 chunk |
+0 lines, -33 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/extensions/api/chrome_extensions_api_client.cc
|
View
|
|
1 chunk |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/policy_value_store.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_apitest.cc
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_backend.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_frontend.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_frontend.cc
|
View
|
|
2 chunks |
+12 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_frontend_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/api/storage/settings_namespace.h
|
View
|
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/api/storage/settings_namespace.cc
|
View
|
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_observer.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_sync_processor.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/settings_test_util.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/storage_api.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/storage/syncable_settings_storage.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/chrome_extensions_browser_client.h
|
View
|
|
2 chunks |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/chrome_extensions_browser_client.cc
|
View
|
|
2 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_extensions.gypi
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
extensions/browser/api/extensions_api_client.h
|
View
|
|
1 chunk |
+0 lines, -56 lines |
0 comments
|
Download
|
 |
D |
extensions/browser/api/extensions_api_client.cc
|
View
|
|
1 chunk |
+0 lines, -27 lines |
0 comments
|
Download
|
 |
D |
extensions/browser/api/storage/settings_namespace.h
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
 |
D |
extensions/browser/api/storage/settings_namespace.cc
|
View
|
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
 |
M |
extensions/extensions.gyp
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|