Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 181233011: Revert of Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert of Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend (https://codereview.chromium.org/180213008/) Reason for revert: Likely broke GCMProfileServiceSingleProfileTest.Unregister Android. Original issue's description: > Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend > > app_shell needs the chrome.storage.local extension API so the core storage implementation is moving to //extensions/browser/api. However, the "managed storage" API implementation needs to remain in Chrome. > > * Introduce ExtensionsApiClient in extensions/browser/api > * Introduce ChromeExtensionsApiClient in chrome/browser/extensions/api > * Delegate out the storage ManagedValueStoreCache creation to Chrome > * Move settings_namespace.h/cc to e/b/api/storage so we can use an enum in the client interface definition > > Most APIs will probably need to make only one or two client interface calls, so we're starting with a single ExtensionsApiClient interface. It we find individual APIs tend to need a lot of methods we can split it into one client interface per API, but that seems like overkill right now. > > BUG=348058 > TEST=unit_tests *Settings* and browser_tests ExtensionSettings* > R=rdevlin.cronin@chromium.org, rockot@chromium.org, yoz@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255069 TBR=rdevlin.cronin@chromium.org,rockot@chromium.org,yoz@chromium.org,jamescook@chromium.org NOTREECHECKS=true NOTRY=true BUG=348058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -268 lines) Patch
M apps/shell/browser/shell_extensions_browser_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M apps/shell/browser/shell_extensions_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/extensions/api/storage/settings_namespace.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/storage/settings_namespace.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D extensions/browser/api/extensions_api_client.h View 1 chunk +0 lines, -56 lines 0 comments Download
D extensions/browser/api/extensions_api_client.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D extensions/browser/api/storage/settings_namespace.h View 1 chunk +0 lines, -34 lines 0 comments Download
D extensions/browser/api/storage/settings_namespace.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend
6 years, 9 months ago (2014-03-05 19:37:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/181233011/1
6 years, 9 months ago (2014-03-05 19:38:04 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:38:11 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 19:38:12 UTC) #4
Failed to apply patch for
chrome/browser/extensions/api/storage/settings_frontend.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/api/storage/settings_frontend.h
  Hunk #1 FAILED at 11.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/api/storage/settings_frontend.h.rej

Patch:       chrome/browser/extensions/api/storage/settings_frontend.h
Index: chrome/browser/extensions/api/storage/settings_frontend.h
diff --git a/chrome/browser/extensions/api/storage/settings_frontend.h
b/chrome/browser/extensions/api/storage/settings_frontend.h
index
70a52c48a54d2cc295a30dfa744f5da1e8f1ac87..abda6c854b7f21d4a44690e3bbfaf1051438d577
100644
--- a/chrome/browser/extensions/api/storage/settings_frontend.h
+++ b/chrome/browser/extensions/api/storage/settings_frontend.h
@@ -11,11 +11,11 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
+#include "chrome/browser/extensions/api/storage/settings_namespace.h"
 #include "chrome/browser/extensions/api/storage/settings_observer.h"
 #include "chrome/browser/extensions/api/storage/settings_storage_factory.h"
 #include
"chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h"
 #include "chrome/browser/extensions/api/storage/value_store_cache.h"
-#include "extensions/browser/api/storage/settings_namespace.h"
 #include "sync/api/syncable_service.h"
 
 namespace content {

Powered by Google App Engine
This is Rietveld 408576698