Update PRESUBMIT.py to be more in sync with Blink CQ

Update PRESUBMIT.py to be more in sync with Blink CQ

BUG=317931
R=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168529

[Dirk Pranke, 2014-03-05 20:46:48]

1) I assume the default test filter is 'defaulttests'?

2) Is there a point to running the presubmit bot here, since you would also
already be running presubmit locally?

[Paweł Hajdan Jr., 2014-03-05 20:49:37]

On 2014/03/05 20:46:48, Dirk Pranke wrote:
> 1) I assume the default test filter is 'defaulttests'?

It is a de-facto default. For recipe bots it has no meaning anyway.

I guess having something else here might be even more confusing.

> 2) Is there a point to running the presubmit bot here, since you would also
> already be running presubmit locally?

I think there is - AFAIK Blink CQ doesn't run presubmit on the cq host, and it's
valuable not to break the presubmit check.

[Dirk Pranke, 2014-03-05 20:50:43]

On 2014/03/05 20:49:37, Paweł Hajdan Jr. wrote:
> On 2014/03/05 20:46:48, Dirk Pranke wrote:
> > 1) I assume the default test filter is 'defaulttests'?
> 
> It is a de-facto default. For recipe bots it has no meaning anyway.
> 
> I guess having something else here might be even more confusing.
> 
> > 2) Is there a point to running the presubmit bot here, since you would also
> > already be running presubmit locally?
> 
> I think there is - AFAIK Blink CQ doesn't run presubmit on the cq host, and
it's
> valuable not to break the presubmit check.

Fair enough. LGTM.

[Paweł Hajdan Jr., 2014-03-05 20:51:34]

Committed patchset #1 manually as r168529 (presubmit successful).