Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issue 1812313002: Several mjsunit cleanups (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Several mjsunit cleanups - Move default parameters tests from harmony/ to es6/ and remove non-existent --harmony-default-parameters flag. - Remove some non-existent tests from mjsunit.status Committed: https://crrev.com/6a8de153227e5a9686e51f82ee5365645f62ccb8 Cr-Commit-Position: refs/heads/master@{#34908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -492 lines) Patch
A + test/mjsunit/es6/debug-stepin-default-parameters.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/default-parameters.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/default-parameters-debug.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-4400.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/debug-stepin-default-parameters.js View 1 chunk +0 lines, -46 lines 0 comments Download
D test/mjsunit/harmony/default-parameters.js View 1 chunk +0 lines, -365 lines 0 comments Download
D test/mjsunit/harmony/default-parameters-debug.js View 1 chunk +0 lines, -58 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4400.js View 1 chunk +0 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 5 chunks +0 lines, -8 lines 0 comments Download
M test/mjsunit/regress/regress-554865.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 9 months ago (2016-03-18 23:05:58 UTC) #2
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-18 23:08:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812313002/1
4 years, 9 months ago (2016-03-18 23:17:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 23:19:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 23:20:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a8de153227e5a9686e51f82ee5365645f62ccb8
Cr-Commit-Position: refs/heads/master@{#34908}

Powered by Google App Engine
This is Rietveld 408576698