webkit/renderer/media/media_load_delegate.h - Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/renderer/media/media_load_delegate.h

Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: trim things down Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/shell/renderer/shell_content_renderer_client.cc ('K') | « content/shell/renderer/webkit_test_runner.cc ('k') | webkit/renderer/media/simple_video_frame_provider.h » ('j') | webkit/renderer/media/webmediaplayer_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WEBKIT_RENDERER_MEDIA_MEDIA_LOAD_DELEGATE_H_

	6 #define WEBKIT_RENDERER_MEDIA_MEDIA_LOAD_DELEGATE_H_

	7

	8 #include "base/callback_forward.h"

	9

	10 namespace webkit_media {

	11

	12 // Allows embedders to control when media players will start loading resources.

	13 class MediaLoadDelegate {

	14 public:

	15 MediaLoadDelegate() {}
	jam 2013/06/28 21:59:40 nit: no constructor needed in the interface (see o nit: no constructor needed in the interface (see other content api interfaces) scherkus (not reviewing) 2013/07/02 01:46:23 Done. Show quoted text On 2013/06/28 21:59:40, jam wrote: > nit: no constructor needed in the interface (see other content api interfaces) Done.
	16 virtual ~MediaLoadDelegate() {}

	17

	18 // Called to defer loading. Implementors can run \|closure\| to continue

	19 // loading the media resource.

	20 virtual void DeferLoad(const base::Closure& closure) = 0;
	jam 2013/06/28 21:59:40 actually, if this is an interface with only one me actually, if this is an interface with only one method, then it shouldn't be an interface. it should just be one callback in ContentRendererClient (see the content api wiki) scherkus (not reviewing) 2013/07/02 01:46:23 I'm not 100% sure what you're referring to ... so Show quoted text On 2013/06/28 21:59:40, jam wrote: > actually, if this is an interface with only one method, then it shouldn't be an > interface. it should just be one callback in ContentRendererClient (see the > content api wiki) I'm not 100% sure what you're referring to ... so I gave this a shot. Let me know if I'm completely off the mark. Unfortunately webkit_media code can't directly call the ContentRendererClient (layering violation!), so that code gets a bit hairy by passing in a callback-to-a-function-accepting-a-closure... but I can clean it up after things move.
	21 };

	22

	23 } // namespace webkit_media

	24

	25 #endif // WEBKIT_RENDERER_MEDIA_MEDIA_LOAD_DELEGATE_H_

OLD	NEW