content/shell/renderer/DEPS - Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/renderer/DEPS

Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 # TODO(scherkus): Use RenderViewImpl::createMediaPlayer() and expose

	3 # proper public APIs for overriding WebRTC components instead of depending

	4 # on internal content objects http://crbug.com/239826
	scherkus (not reviewing) 2013/06/27 21:56:50 jam: I'm assuming these aren't permitted either? jam: I'm assuming these aren't permitted either? some of these are interfaces (e.g., VideoFrameProvider, MediaStreamClient) -- is it acceptable to move them to content/public/renderer/ ? jam 2013/06/28 00:31:58 correct Show quoted text On 2013/06/27 21:56:50, scherkus wrote: > jam: I'm assuming these aren't permitted either? correct Show quoted text > > some of these are interfaces (e.g., VideoFrameProvider, MediaStreamClient) -- is > it acceptable to move them to content/public/renderer/ ? sure if an interface is needed to be implemented by an embedder, or to be called by an embedder, we can move it. but we should only expose what's necessary for the embedder
	5 "+content/renderer/media/video_frame_provider.h",

	6 "+content/renderer/media/media_stream_client.h",

	7 "+content/renderer/media/media_stream_audio_renderer.h",

	8 "+content/renderer/media/webmediaplayer_impl.h",

	9 "+content/renderer/media/webmediaplayer_ms.h",

	10 "+content/renderer/media/webmediaplayer_params.h",

2 "+media/base", # For media::MediaLog.	11 "+media/base", # For media::MediaLog.

3 ]	12 ]

OLD	NEW