chrome/renderer/prerender/DEPS - Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/prerender/DEPS

Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 include_rules = [

	2 # TODO(shishir): We should not be depending on content internals objects.

	3 # XXX FILE BUG XXX

	4 "+content/renderer/media/webmediaplayer_impl.h",
	jam 2013/06/27 21:22:51 can't do this.. chrome can't include anything inte can't do this.. chrome can't include anything internal from content even temporarily. please see the content api wiki http://www.chromium.org/developers/content-module/content-api since we don't have implementation inheritance in the content api, how we usually solve this is moving to containment instead scherkus (not reviewing) 2013/06/27 21:29:31 Can you give an example? Do you mean wrapping a W Show quoted text On 2013/06/27 21:22:51, jam wrote: > can't do this.. chrome can't include anything internal from content even > temporarily. please see the content api wiki > http://www.chromium.org/developers/content-module/content-api > > since we don't have implementation inheritance in the content api, how we > usually solve this is moving to containment instead Can you give an example? Do you mean wrapping a WebKit::WebMediaPlayer object + reimplementing the interface + forwarding all the methods? As an aside ... do you know why this scrutiny wasn't applied to anything under src/webkit/ during content-ification of chrome? Was it out of scope? jam 2013/06/28 00:31:58 what i mean is that the prerendering code doesn't Show quoted text On 2013/06/27 21:29:31, scherkus wrote: > On 2013/06/27 21:22:51, jam wrote: > > can't do this.. chrome can't include anything internal from content even > > temporarily. please see the content api wiki > > http://www.chromium.org/developers/content-module/content-api > > > > since we don't have implementation inheritance in the content api, how we > > usually solve this is moving to containment instead > > Can you give an example? > > Do you mean wrapping a WebKit::WebMediaPlayer object + reimplementing the > interface + forwarding all the methods? what i mean is that the prerendering code doesn't implement the interface, it inherits from the implementation. we don't allow implementation inheritance in the content api, since that would mean exposing internal implementation details of content. it's best to study that code to see exactly what prerendering needs to do. there may be simpler ways of achieving this. Show quoted text > > As an aside ... do you know why this scrutiny wasn't applied to anything under > src/webkit/ during content-ification of chrome? Was it out of scope? the chrome/content split was done for code in src/chrome. we didn't touch other top level directories like wekbit, net etc.
	5 ]

OLD	NEW

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/prerender/prerender_webmediaplayer.h » ('j') | content/shell/renderer/DEPS » ('J')