Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4445)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index 9af0c09db71460153911cffb102d6606dd62573f..f1114eddecc89bd808ccc0d4f25d37a1b0bb974d 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -18,6 +18,7 @@
using base::android::JavaParamRef;
using base::android::ToJavaArrayOfStrings;
+using base::android::ToJavaLongArray;
using ntp_snippets::NTPSnippetsService;
using ntp_snippets::NTPSnippetsServiceObserver;
@@ -59,11 +60,13 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded(NTPSnippetsService* service) {
std::vector<std::string> urls;
std::vector<std::string> thumbnail_urls;
std::vector<std::string> snippets;
+ std::vector<int64_t> timestamps;
for (const ntp_snippets::NTPSnippet& snippet : *service) {
titles.push_back(snippet.title());
urls.push_back(snippet.url().spec());
thumbnail_urls.push_back(snippet.salient_image_url().spec());
snippets.push_back(snippet.snippet());
+ timestamps.push_back(snippet.publish_date().ToJavaTime());
}
JNIEnv* env = base::android::AttachCurrentThread();
@@ -71,7 +74,8 @@ void NTPSnippetsBridge::NTPSnippetsServiceLoaded(NTPSnippetsService* service) {
env, observer_.obj(), ToJavaArrayOfStrings(env, titles).obj(),
ToJavaArrayOfStrings(env, urls).obj(),
ToJavaArrayOfStrings(env, thumbnail_urls).obj(),
- ToJavaArrayOfStrings(env, snippets).obj());
+ ToJavaArrayOfStrings(env, snippets).obj(),
+ ToJavaLongArray(env, timestamps).obj());
}
void NTPSnippetsBridge::NTPSnippetsServiceShutdown(

Powered by Google App Engine
This is Rietveld 408576698