Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/NewTabPageListItemViewHolder.java

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/NewTabPageListItemViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetListItemViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/NewTabPageListItemViewHolder.java
similarity index 78%
rename from chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetListItemViewHolder.java
rename to chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/NewTabPageListItemViewHolder.java
index 75dc552711a1baaccfcbf07a3a478d7172559e7d..d9a09f75e4f99b90941f7a36ce7cdbafff2f754e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetListItemViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/NewTabPageListItemViewHolder.java
@@ -7,12 +7,12 @@ package org.chromium.chrome.browser.ntp.snippets;
import android.support.v7.widget.RecyclerView;
import android.view.View;
-import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetListItem;
+import org.chromium.chrome.browser.ntp.NewTabPageCardsManager.NewTabPageListItem;
/**
* A class that represents an item we want to display in our list of card snippets.
newt (away) 2016/03/23 05:29:39 Update this comment, esp since the "main NTP conte
May 2016/03/23 19:22:57 Done.
*/
-abstract class SnippetListItemViewHolder extends RecyclerView.ViewHolder {
+abstract class NewTabPageListItemViewHolder extends RecyclerView.ViewHolder {
newt (away) 2016/03/23 05:29:39 We could probably make this name a bit more concis
May 2016/03/23 19:22:57 Done.
private final SnippetsManager mManager;
/**
@@ -22,7 +22,7 @@ abstract class SnippetListItemViewHolder extends RecyclerView.ViewHolder {
* @param cardView The View for this item
* @param manager The SnippetsManager object used to open an article
*/
- public SnippetListItemViewHolder(View itemView, SnippetsManager manager) {
+ public NewTabPageListItemViewHolder(View itemView, SnippetsManager manager) {
super(itemView);
mManager = manager;
}
@@ -42,5 +42,5 @@ abstract class SnippetListItemViewHolder extends RecyclerView.ViewHolder {
*
* @param article The SnippetListItem object that holds the data for this ViewHolder
newt (away) 2016/03/23 05:29:39 update javadoc and param name
May 2016/03/23 19:22:57 Done.
*/
- public abstract void onBindViewHolder(SnippetListItem snippetItem);
+ public abstract void onBindViewHolder(NewTabPageListItem snippetItem);
}

Powered by Google App Engine
This is Rietveld 408576698