third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h

index 7bfa563cae08989742d1172fecef682d9bd26b10..d150a56bb5a874a98d140a44c218e9b5d9333258 100644

--- a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h

+++ b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h

@@ -65,7 +65,7 @@ public:

BMPImageReader(ImageDecoder* parent, size_t decodedAndHeaderOffset, size_t imgDataOffset, bool isInICO);

void setBuffer(ImageFrame* buffer) { m_buffer = buffer; }

- void setData(SharedBuffer* data)

+ void setData(SegmentReader* data)

{

m_data = data;

m_fastReader.setData(data);

@@ -290,7 +290,7 @@ private:

ImageFrame* m_buffer;

// The file to decode.

- RefPtr<SharedBuffer> m_data;

+ RefPtr<SegmentReader> m_data;

FastSharedBufferReader m_fastReader;

// An index into |m_data| representing how much we've already decoded.