third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a leak; remove unnecessary comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h ('k') | third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

index ce5a2f5813707ffd96d654517ea30ee105322ddf..d85d5fef5d3e10be19512538d9ac9f7bcc5a88a5 100644

--- a/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp

@@ -162,7 +162,7 @@ void WEBPImageDecoder::clearDecoder()

m_frameBackgroundHasAlpha = false;

}

-void WEBPImageDecoder::onSetData(SharedBuffer*)

+void WEBPImageDecoder::onSetData(SegmentReader*)

{

m_haveAlreadyParsedThisData = false;

}

@@ -202,7 +202,8 @@ bool WEBPImageDecoder::updateDemuxer()

return false; // Await VP8X header so WebPDemuxPartial succeeds.

WebPDemuxDelete(m_demux);

- WebPData inputData = { reinterpret_cast<const uint8_t*>(m_data->data()), m_data->size() };

+ m_encodedData = m_data->getAsSkData();

+ WebPData inputData = { reinterpret_cast<const uint8_t*>(m_encodedData->data()), m_encodedData->size() };

m_demux = WebPDemuxPartial(&inputData, &m_demuxState);

if (!m_demux || (isAllDataReceived() && m_demuxState != WEBP_DEMUX_DONE))

return setFailed();