third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add tests for other formats Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h ('k') | third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp

index 4c6631dfe2b4ea139902f443fdf716cde83a9c68..07366f40171002e5f776bdbb832b1d6f0fcf33a8 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp

@@ -387,7 +387,10 @@ bool GIFImageReader::decode(size_t frameIndex)

bool GIFImageReader::parse(GIFImageDecoder::GIFParseQuery query)

{

- ASSERT(m_bytesRead <= m_data->size());

+ if (m_bytesRead >= m_data->size()) {

Peter Kasting 2016/04/12 22:56:25 Add a comment describing the sequence that can res

scroggo_chromium 2016/04/13 12:16:43 Done.

+ // This data has already been parsed.

+ return !m_client->failed();

+ }

return parseData(m_bytesRead, m_data->size() - m_bytesRead, query);

}