third_party/WebKit/Source/web/ImageDecodeBench.cpp - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ImageDecodeBench.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert to PassRefPtr in ImageDecoder, helper for setData Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ImageDecodeBench.cpp

diff --git a/third_party/WebKit/Source/web/ImageDecodeBench.cpp b/third_party/WebKit/Source/web/ImageDecodeBench.cpp

index 6c8ecc1aa7af9bdd100705426c395f9ff6a08b29..7341bc853d389a9367e8b87e0209e11bcaca8ef3 100644

--- a/third_party/WebKit/Source/web/ImageDecodeBench.cpp

+++ b/third_party/WebKit/Source/web/ImageDecodeBench.cpp

@@ -23,6 +23,7 @@ http://crbug.com/398235#c103 and http://crbug.com/258324#c5

#include "platform/SharedBuffer.h"

#include "platform/image-decoders/ImageDecoder.h"

+#include "platform/image-decoders/SharedBufferSegmentReader.h"

#include "platform/testing/TestingPlatformSupport.h"

#include "public/platform/Platform.h"

#include "public/web/WebKit.h"

@@ -294,7 +295,7 @@ bool decodeImageData(SharedBuffer* data, bool colorCorrection, size_t packetSize

position += length;

bool allDataReceived = position == data->size();

- decoder->setData(packetData.get(), allDataReceived);

+ decoder->setData(packetData, allDataReceived);

int frameCount = decoder->frameCount();

for (int i = 0; i < frameCount; ++i) {