Eliminate copies of encoded image data

third_party/WebKit/Source/platform/blink_platform.gypi

Index: third_party/WebKit/Source/platform/blink_platform.gypi
diff --git a/third_party/WebKit/Source/platform/blink_platform.gypi b/third_party/WebKit/Source/platform/blink_platform.gypi
index b974e62fdcd9893e23a678e0e73d2b92961bc3cd..80cdb55ef89bd87b5f03a37cfcc6a2a9beb2917f 100644
--- a/third_party/WebKit/Source/platform/blink_platform.gypi
+++ b/third_party/WebKit/Source/platform/blink_platform.gypi
@@ -599,8 +599,6 @@
       'graphics/StaticBitmapImage.h',
       'graphics/StrokeData.cpp',
       'graphics/StrokeData.h',
-      'graphics/ThreadSafeDataTransport.cpp',
-      'graphics/ThreadSafeDataTransport.h',
       'graphics/UnacceleratedImageBufferSurface.cpp',
       'graphics/UnacceleratedImageBufferSurface.h',
       'graphics/compositing/PaintArtifactCompositor.cpp',
@@ -740,6 +738,13 @@
       'image-decoders/ImageDecoder.h',
       'image-decoders/ImageFrame.cpp',
       'image-decoders/ImageFrame.h',
+      'image-decoders/ROBufferSegmentReader.cpp',
+      'image-decoders/ROBufferSegmentReader.h',

[Peter Kasting, 2016/03/23 02:42:57]

Nit: I think it would be nicer to spell out "ReadOnly" in the file name instead
of saving a few characters with "RO".

[scroggo_chromium, 2016/03/24 13:59:44]

This reads from an object called "SkROBuffer", so I think this name makes more
sense, unless we change the name of the Skia class.

[Peter Kasting, 2016/03/24 22:05:43]

It's a judgment call.  I would try to apply the same logic here as for
DataSegmentReader -- do we want to closely match the underlying Skia type name
(in which case SkDataSegmentReader might be better) or are we trying to write a
name that's readable without reference to the SKia typename, or somewhere in the
middle?

I would probably prefer SkROBufferSegmentReader and ReadOnlyBufferSegmentReader
to ROBufferSegmentReader, but all have their downsides, so as long as you're
consistent in the end go with what you think is best.

[scroggo_chromium, 2016/03/25 01:05:10]

I've stuck with DataSegmentReader and ROBufferSegmentReader, which both mirror
their Skia types minus the Sk. I also moved them into factories, so if we don't
like the names we can change them in few places.

+      'image-decoders/SharedBufferSegmentReader.cpp',
+      'image-decoders/SharedBufferSegmentReader.h',
+      'image-decoders/SegmentReader.h',
+      'image-decoders/SkDataSegmentReader.h',
+      'image-decoders/SkDataSegmentReader.cpp',
       'image-decoders/bmp/BMPImageDecoder.cpp',
       'image-decoders/bmp/BMPImageDecoder.h',
       'image-decoders/bmp/BMPImageReader.cpp',
@@ -1025,7 +1030,6 @@
       'graphics/ContiguousContainerTest.cpp',
       'graphics/GraphicsContextTest.cpp',
       'graphics/RecordingImageBufferSurfaceTest.cpp',
-      'graphics/ThreadSafeDataTransportTest.cpp',
       'graphics/filters/FilterOperationsTest.cpp',
       'graphics/filters/ImageFilterBuilderTest.cpp',
       'graphics/gpu/DrawingBufferTest.cpp',