Convert leveldb_apptests to unit tests.

Convert leveldb_apptests to unit tests.

BUG=594731
R=sky@chromium.org
TBR=dpranke@chromium.org

Committed: https://crrev.com/f1f689fb5b3ede5756b138e617ed7c879f181cec
Cr-Commit-Position: refs/heads/master@{#382464}

[Elliot Glaysher, 2016-03-18 21:53:21]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-03-18 23:03:07]

LGTM

[Elliot Glaysher, 2016-03-18 23:03:47]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2016-03-18 23:04:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812263004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812263004/40001

[commit-bot: I haz the power, 2016-03-18 23:13:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 23:13:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elliot Glaysher, 2016-03-18 23:21:47]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-03-18 23:21:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1812263004/#ps60001
(title: "fix mid air collision")

[commit-bot: I haz the power, 2016-03-18 23:22:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812263004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812263004/60001

[commit-bot: I haz the power, 2016-03-18 23:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 23:49:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elliot Glaysher, 2016-03-21 20:06:11]

erg@chromium.org changed reviewers:
+ dpranke@chromium.org

[Elliot Glaysher, 2016-03-21 20:06:12]

Dirk: toplevel BUILD.gn OWNERS approval?

[Elliot Glaysher, 2016-03-21 22:43:54]

Description was changed from

==========
Convert leveldb_apptests to unit tests.

BUG=594731
==========

to

==========
Convert leveldb_apptests to unit tests.

BUG=594731
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

[Elliot Glaysher, 2016-03-21 22:44:01]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-03-21 22:44:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1812263004/#ps80001
(title: "Rebase to ToT")

[Elliot Glaysher, 2016-03-21 22:44:17]

On 2016/03/21 20:06:12, Elliot Glaysher wrote:
> Dirk: toplevel BUILD.gn OWNERS approval?

(nm, following sky@'s lead and TBRing this trivial change.)

[commit-bot: I haz the power, 2016-03-21 22:44:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812263004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812263004/80001

[Dirk Pranke, 2016-03-21 22:55:06]

https://codereview.chromium.org/1812263004/diff/80001/testing/buildbot/chromi...
File testing/buildbot/chromium.linux.json (right):

https://codereview.chromium.org/1812263004/diff/80001/testing/buildbot/chromi...
testing/buildbot/chromium.linux.json:774: },
why isn't this using swarming? We don't normally run test binaries that aren't
swarmed these days.

[Elliot Glaysher, 2016-03-21 22:56:32]

The CQ bit was unchecked by erg@chromium.org

[Elliot Glaysher, 2016-03-22 00:08:34]

On 2016/03/21 22:55:06, Dirk Pranke wrote:
>
https://codereview.chromium.org/1812263004/diff/80001/testing/buildbot/chromi...
> File testing/buildbot/chromium.linux.json (right):
> 
>
https://codereview.chromium.org/1812263004/diff/80001/testing/buildbot/chromi...
> testing/buildbot/chromium.linux.json:774: },
> why isn't this using swarming? We don't normally run test binaries that aren't
> swarmed these days.

Switched to swarming. (And changed the name of the target like you asked on
sky's patch.)

[Dirk Pranke, 2016-03-22 00:11:11]

thanks, lgtm.

[Elliot Glaysher, 2016-03-22 00:12:06]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-03-22 00:12:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1812263004/#ps120001
(title: "Remove output_name")

[commit-bot: I haz the power, 2016-03-22 00:12:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812263004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812263004/120001

[commit-bot: I haz the power, 2016-03-22 00:51:28]

Description was changed from

==========
Convert leveldb_apptests to unit tests.

BUG=594731
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

to

==========
Convert leveldb_apptests to unit tests.

BUG=594731
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-03-22 00:51:29]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-22 00:52:41]

Description was changed from

==========
Convert leveldb_apptests to unit tests.

BUG=594731
R=sky@chromium.org
TBR=dpranke@chromium.org
==========

to

==========
Convert leveldb_apptests to unit tests.

BUG=594731
R=sky@chromium.org
TBR=dpranke@chromium.org

Committed: https://crrev.com/f1f689fb5b3ede5756b138e617ed7c879f181cec
Cr-Commit-Position: refs/heads/master@{#382464}
==========

[commit-bot: I haz the power, 2016-03-22 00:52:42]

Patchset 7 (id:??) landed as
https://crrev.com/f1f689fb5b3ede5756b138e617ed7c879f181cec
Cr-Commit-Position: refs/heads/master@{#382464}