fix windows build; add blend modes

fix windows build; add blend modes

Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.

Add a translation from PDF's blend modes to Skia's xfer modes.

Turn on subpixel positioning for text to get more precise
glyph placement.

Pass the alpha through to get proper bitmap transparency.

Address earlier nits.

R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair

Committed: https://pdfium.googlesource.com/pdfium/+/cf6bffb79f6e62d096908e6629daba5525728272

[Tom Sepez, 2016-03-18 20:34:52]

lgtm

[dsinclair, 2016-03-18 23:23:27]

https://codereview.chromium.org/1812263002/diff/1/skia/skia_library.gypi
File skia/skia_library.gypi (left):

https://codereview.chromium.org/1812263002/diff/1/skia/skia_library.gypi#oldc...
skia/skia_library.gypi:41:
'../third_party/skia/src/ports/SkFontMgr_empty_factory.cpp',
Does this still build on linux if you remove this line? If not, I can try to
make it work once this is committed. Will just need a conditional block to put
this file in I think.

[caryclark, 2016-03-21 11:23:16]

On 2016/03/18 23:23:27, dsinclair wrote:
> https://codereview.chromium.org/1812263002/diff/1/skia/skia_library.gypi
> File skia/skia_library.gypi (left):
> 
>
https://codereview.chromium.org/1812263002/diff/1/skia/skia_library.gypi#oldc...
> skia/skia_library.gypi:41:
> '../third_party/skia/src/ports/SkFontMgr_empty_factory.cpp',
> Does this still build on linux if you remove this line? If not, I can try to
> make it work once this is committed. Will just need a conditional block to put
> this file in I think.

I'm working on a new CL on the Skia side which will permit the Windows port to
use FreeType instead of DirectWrite. Since PDFium calls the graphics engine to
draw text but measures the text directly, the same underlying font metrics need
to be used in both places. I'm going to hold off on this CL until I get that
work done.

[caryclark, 2016-03-21 16:33:29]

Description was changed from

==========
fix windows build; add blend modes

fix windows build; add blend modes

Use the SkFontMgr to initalize the Windows Direct Write environment.

Add a translation from PDF's blend modes to Skia's xfer modes.

Address earlier nits.

R=dsinclair,tsepez@chromium.org
==========

to

==========
fix windows build; add blend modes

Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.

Add a translation from PDF's blend modes to Skia's xfer modes.

Turn on subpixel positioning for text to get more precise
glyph placement.

Pass the alpha through to get proper bitmap transparency.

Address earlier nits.

R=dsinclair,tsepez@chromium.org
==========

[caryclark, 2016-03-21 16:44:22]

note that Skia DEPS needs to be updated before this CL makes sense -- not sure
if it breaks non-Skia builds or other platforms' skia/non-skia builds...

[dsinclair, 2016-03-21 16:45:32]

On 2016/03/21 16:44:22, caryclark wrote:
> note that Skia DEPS needs to be updated before this CL makes sense -- not sure
> if it breaks non-Skia builds or other platforms' skia/non-skia builds...

Updating the skia revision should be fine. I just added it a few days ago so it
should effect nothing else.

[caryclark, 2016-03-24 00:58:50]

PTAL. This works with the current Skia DEPS and strips out the more complicated
parts of the CL so they can be considered separately.

[dsinclair, 2016-03-24 01:45:45]

https://codereview.chromium.org/1812263002/diff/100001/core/fxge/skia/fx_skia...
File core/fxge/skia/fx_skia_device.cpp (right):

https://codereview.chromium.org/1812263002/diff/100001/core/fxge/skia/fx_skia...
core/fxge/skia/fx_skia_device.cpp:100: static SkMatrix ToSkMatrix(const
CFX_Matrix& m) {
nit: Can these statics move into an anonymous namespace? (can be done later)

https://codereview.chromium.org/1812263002/diff/100001/third_party/third_part...
File third_party/third_party.gyp (right):

https://codereview.chromium.org/1812263002/diff/100001/third_party/third_part...
third_party/third_party.gyp:66: 'freetype/src/base/ftfstype.c',
Do these need to be added only if we're in pdfium_use_skia?

[caryclark, 2016-03-24 13:48:03]

https://codereview.chromium.org/1812263002/diff/100001/core/fxge/skia/fx_skia...
File core/fxge/skia/fx_skia_device.cpp (right):

https://codereview.chromium.org/1812263002/diff/100001/core/fxge/skia/fx_skia...
core/fxge/skia/fx_skia_device.cpp:100: static SkMatrix ToSkMatrix(const
CFX_Matrix& m) {
On 2016/03/24 01:45:45, dsinclair wrote:
> nit: Can these statics move into an anonymous namespace? (can be done later)

Done.

https://codereview.chromium.org/1812263002/diff/100001/third_party/third_part...
File third_party/third_party.gyp (right):

https://codereview.chromium.org/1812263002/diff/100001/third_party/third_part...
third_party/third_party.gyp:66: 'freetype/src/base/ftfstype.c',
On 2016/03/24 01:45:45, dsinclair wrote:
> Do these need to be added only if we're in pdfium_use_skia?

Done.

[dsinclair, 2016-03-24 14:19:09]

lgtm

[caryclark, 2016-03-24 14:23:20]

Description was changed from

==========
fix windows build; add blend modes

Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.

Add a translation from PDF's blend modes to Skia's xfer modes.

Turn on subpixel positioning for text to get more precise
glyph placement.

Pass the alpha through to get proper bitmap transparency.

Address earlier nits.

R=dsinclair,tsepez@chromium.org
==========

to

==========
fix windows build; add blend modes

Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.

Add a translation from PDF's blend modes to Skia's xfer modes.

Turn on subpixel positioning for text to get more precise
glyph placement.

Pass the alpha through to get proper bitmap transparency.

Address earlier nits.

R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair

Committed:
https://pdfium.googlesource.com/pdfium/+/cf6bffb79f6e62d096908e6629daba552572...
==========

[caryclark, 2016-03-24 14:23:21]

Committed patchset #7 (id:120001) manually as
cf6bffb79f6e62d096908e6629daba5525728272 (presubmit successful).