components/test_runner/test_plugin.cc - Issue 1812243003: Remove methods from WebGraphicsContext3D that wrap type casts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_plugin.cc

Issue 1812243003: Remove methods from WebGraphicsContext3D that wrap type casts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simples-tplus

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/test_plugin.cc

diff --git a/components/test_runner/test_plugin.cc b/components/test_runner/test_plugin.cc

index dcd3beb33dd56744bed1247131e0904ed7d90228..f98e0a8afd982e8595490d73aad8dc1518e7acbd 100644

--- a/components/test_runner/test_plugin.cc

+++ b/components/test_runner/test_plugin.cc

@@ -491,8 +491,8 @@ void TestPlugin::DrawPrimitive() {

// Bind primitive vertices.

gl_->BindBuffer(GL_ARRAY_BUFFER, scene_.vbo);

gl_->EnableVertexAttribArray(scene_.position_location);

- context_->vertexAttribPointer(

- scene_.position_location, 3, GL_FLOAT, GL_FALSE, 0, 0);

+ gl_->VertexAttribPointer(scene_.position_location, 3, GL_FLOAT, GL_FALSE, 0,

+ nullptr);

gl_->DrawArrays(GL_TRIANGLES, 0, 3);

}

« no previous file with comments | « no previous file | gpu/blink/webgraphicscontext3d_impl.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')