Make net pass "gn check"

Make net pass "gn check"

Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools. This abstract interface is used in both places, and the dependency goes in the opposite direction as it was used before.

Added some "nogncheck" annotations on headers conditionally included where the conditional dependencies correctly match the conditional includes.

Add some websockets headers to the shared net sources target. As explained in the comment I added there, the these headers are used but there are no link-time dependencies so the websockets implementation can still be conditionally excluded. I prefer this method rather than a nogncheck annotation when there's no clear conditional include.

Removed an unused FTP include from url_request_context_storage.cc

Committed: https://crrev.com/25ca89217973cdd1ce2cac09cb1603a58f8a4a6a
Cr-Commit-Position: refs/heads/master@{#382119}

[brettw, 2016-03-18 18:11:41]

Description was changed from

==========
Make net pass "gn check"
==========

to

==========
Make net pass "gn check"

Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools.
This abstract interface is used in both places, and the dependency goes in the
opposite direction as it was used before.

Added some "nogncheck" annotations on headers conditionally included where the
conditional dependencies correctly match the conditional includes.

Add some websockets headers to the shared net sources target. As explained in
the comment I added there, the these headers are used but there are no link-time
dependencies so the websockets implementation can still be conditionally
excluded. I prefer this method rather than a nogncheck annotation when there's
no clear conditional include.

Removed an unused FTP include from url_request_context_storage.cc
==========

[brettw, 2016-03-18 18:11:41]

brettw@chromium.org changed reviewers:
+ rsleevi@chromium.org

[brettw, 2016-03-18 18:13:15]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 18:14:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812243002/20001

[commit-bot: I haz the power, 2016-03-18 18:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 18:19:31]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[brettw, 2016-03-18 21:10:33]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 21:10:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812243002/40001

[Ryan Sleevi, 2016-03-18 21:14:39]

lgtm

[brettw, 2016-03-18 21:18:25]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-03-18 21:18:25]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-03-18 21:18:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812243002/40001

[commit-bot: I haz the power, 2016-03-18 23:00:05]

Description was changed from

==========
Make net pass "gn check"

Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools.
This abstract interface is used in both places, and the dependency goes in the
opposite direction as it was used before.

Added some "nogncheck" annotations on headers conditionally included where the
conditional dependencies correctly match the conditional includes.

Add some websockets headers to the shared net sources target. As explained in
the comment I added there, the these headers are used but there are no link-time
dependencies so the websockets implementation can still be conditionally
excluded. I prefer this method rather than a nogncheck annotation when there's
no clear conditional include.

Removed an unused FTP include from url_request_context_storage.cc
==========

to

==========
Make net pass "gn check"

Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools.
This abstract interface is used in both places, and the dependency goes in the
opposite direction as it was used before.

Added some "nogncheck" annotations on headers conditionally included where the
conditional dependencies correctly match the conditional includes.

Add some websockets headers to the shared net sources target. As explained in
the comment I added there, the these headers are used but there are no link-time
dependencies so the websockets implementation can still be conditionally
excluded. I prefer this method rather than a nogncheck annotation when there's
no clear conditional include.

Removed an unused FTP include from url_request_context_storage.cc
==========

[commit-bot: I haz the power, 2016-03-18 23:00:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 23:02:19]

Description was changed from

==========
Make net pass "gn check"

Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools.
This abstract interface is used in both places, and the dependency goes in the
opposite direction as it was used before.

Added some "nogncheck" annotations on headers conditionally included where the
conditional dependencies correctly match the conditional includes.

Add some websockets headers to the shared net sources target. As explained in
the comment I added there, the these headers are used but there are no link-time
dependencies so the websockets implementation can still be conditionally
excluded. I prefer this method rather than a nogncheck annotation when there's
no clear conditional include.

Removed an unused FTP include from url_request_context_storage.cc
==========

to

==========
Make net pass "gn check"

Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools.
This abstract interface is used in both places, and the dependency goes in the
opposite direction as it was used before.

Added some "nogncheck" annotations on headers conditionally included where the
conditional dependencies correctly match the conditional includes.

Add some websockets headers to the shared net sources target. As explained in
the comment I added there, the these headers are used but there are no link-time
dependencies so the websockets implementation can still be conditionally
excluded. I prefer this method rather than a nogncheck annotation when there's
no clear conditional include.

Removed an unused FTP include from url_request_context_storage.cc

Committed: https://crrev.com/25ca89217973cdd1ce2cac09cb1603a58f8a4a6a
Cr-Commit-Position: refs/heads/master@{#382119}
==========

[commit-bot: I haz the power, 2016-03-18 23:02:20]

Patchset 3 (id:??) landed as
https://crrev.com/25ca89217973cdd1ce2cac09cb1603a58f8a4a6a
Cr-Commit-Position: refs/heads/master@{#382119}