Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1812203002:
[heap] Move mark-compact specific code to MarkCompactEpilogue (Closed)
|
Created:
4 years, 9 months ago by Marcel Hlopko Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Move mark-compact specific code to MarkCompactEpilogue
BUG=
LOG=no
Committed: https://crrev.com/e3680e9c68abc0fee5a5d578ef0f4586cadc9daa
Cr-Commit-Position: refs/heads/master@{#34941}
Patch Set 1 #Patch Set 2 : Fix mh's incaution #
Total comments: 2
Patch Set 3 : Move dcheck over to the MarkCompactEpilogue #Messages
Total messages: 20 (9 generated)
The CQ bit was checked by hlopko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812203002/1
hlopko@chromium.org changed reviewers: + hpayer@google.com, ulan@chromium.org
ptal I'm not sure the comment 'the assertion cant be moved down' is needed and relevant. I don't see why would I want to move it down. Feel free to educate me :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/3147) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...) v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17263)
Don't waste time on this one until I investigate the failures, thanks!
Ok, fixed, pta(a)l :) v8_win_rel_ng_triggered is flaky (is ignoring the flakiness the correct way to handle such failures for me at the moment? :)
hpayer@chromium.org changed reviewers: + hpayer@chromium.org
https://codereview.chromium.org/1812203002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1812203002/diff/20001/src/heap/heap.cc#newcod... src/heap/heap.cc:1327: if (collector != SCAVENGER) DCHECK(incremental_marking()->IsStopped()); Please move this check also into the MarkCompactEpilogue.
Description was changed from ========== [heap] Move mark-compact specific code to MarkCompactEpilogue BUG= LOG=no ========== to ========== [heap] Move mark-compact specific code to MarkCompactEpilogue BUG= LOG=no ==========
hpayer@chromium.org changed reviewers: - hpayer@google.com
https://codereview.chromium.org/1812203002/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1812203002/diff/20001/src/heap/heap.cc#newcod... src/heap/heap.cc:1327: if (collector != SCAVENGER) DCHECK(incremental_marking()->IsStopped()); On 2016/03/21 11:55:22, Hannes Payer wrote: > Please move this check also into the MarkCompactEpilogue. Done.
lgtm
The CQ bit was checked by hlopko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812203002/40001
Message was sent while issue was closed.
Description was changed from ========== [heap] Move mark-compact specific code to MarkCompactEpilogue BUG= LOG=no ========== to ========== [heap] Move mark-compact specific code to MarkCompactEpilogue BUG= LOG=no ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Move mark-compact specific code to MarkCompactEpilogue BUG= LOG=no ========== to ========== [heap] Move mark-compact specific code to MarkCompactEpilogue BUG= LOG=no Committed: https://crrev.com/e3680e9c68abc0fee5a5d578ef0f4586cadc9daa Cr-Commit-Position: refs/heads/master@{#34941} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e3680e9c68abc0fee5a5d578ef0f4586cadc9daa Cr-Commit-Position: refs/heads/master@{#34941} |
