Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1812193003: MIPS64: Fix test Cvt_s_uw_Trunc_uw_s. (Closed)

Created:
4 years, 9 months ago by Ilija.Pavlovic1
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix test Cvt_s_uw_Trunc_uw_s. The higher word (bits 32 - 63) of FPU register is set on zero before storing result. TEST=cctest/test-macro-assembler-mips64/Cvt_s_uw_Trunc_uw_s BUG= Committed: https://crrev.com/a4e5d1541a10b4d4da8dc33250cb75df2c43154f Cr-Commit-Position: refs/heads/master@{#34889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/test-macro-assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ilija.Pavlovic1
PTAL. The change is small. I would ask you to do a quick review. Best ...
4 years, 9 months ago (2016-03-18 11:30:57 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 9 months ago (2016-03-18 12:45:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812193003/1
4 years, 9 months ago (2016-03-18 12:46:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 13:21:32 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 13:22:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4e5d1541a10b4d4da8dc33250cb75df2c43154f
Cr-Commit-Position: refs/heads/master@{#34889}

Powered by Google App Engine
This is Rietveld 408576698