Chromium Code Reviews| Index: scripts/master/chromium_step.py |
| diff --git a/scripts/master/chromium_step.py b/scripts/master/chromium_step.py |
| index 5f11771950e506b6a65d876a3909fbd47d2a8c40..bf6f68a407deedf1b20a040fb94dbea86b1a50d9 100644 |
| --- a/scripts/master/chromium_step.py |
| +++ b/scripts/master/chromium_step.py |
| @@ -505,6 +505,10 @@ class AnnotationObserver(buildstep.LogLineObserver): |
| @@@STEP_LINK@<label>@<url>@@@ |
| Add a link with label <label> linking to <url> to the current stage. |
| + If the label value is of the form "text-->base", this is considered an alias |
| + link, and will add an alias named "text" with the value "url" to the log or |
| + link named "base". |
| + |
| @@@STEP_STARTED@@@ |
| Start the step at the cursor location. |
| @@ -1024,8 +1028,16 @@ class AnnotationObserver(buildstep.LogLineObserver): |
| os.chmod(graph_filename, EXECUTABLE_FILE_PERMISSIONS) |
| def addLinkToCursor(self, link_label, link_url): |
| - self.cursor['links'].append((link_label, link_url)) |
| - self.cursor['step'].addURL(link_label, link_url) |
| + parts = link_label.split('-->', 1) |
|
dnj
2016/03/18 01:52:46
I'm not a huge fan of "-->". If something inspirin
|
| + link_alias = None |
| + if len(parts) == 2: |
| + link_alias, link_label = parts |
| + |
| + self.cursor['links'].append((link_label, link_url, link_alias)) |
| + if not link_alias: |
| + self.cursor['step'].addURL(link_label, link_url, alias_text=link_alias) |
| + else: |
| + self.cursor['step'].addAlias(link_label, link_url, text=link_alias) |
| def handleOutputLine(self, line): |
| """This is called once with each line of the test log.""" |